Summary: | [webkit-patch] Use commit.webkit.org instead of remote SVN to compute identifier | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jonathan Bedard
2021-03-26 14:36:22 PDT
Created attachment 424406 [details]
Patch
Comment on attachment 424406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424406&action=review > Tools/Scripts/webkitpy/tool/comments.py:42 > + repr = 'r{}'.format(svn_revision) > + response = requests.get('https://commits.webkit.org/{}/json'.format(repr)) > + if response.status_code == 200: > + repr = response.json().get('identifier', repr) > + return 'Committed r{} ({}): <{}>'.format(svn_revision, repr if '@' in repr else '?', urls.view_identifier_url(repr)) Should we consider using svn.webkit.org as a fallback just in case the former is down? r=me with comment. (In reply to dewei_zhu from comment #3) > Comment on attachment 424406 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424406&action=review > > > Tools/Scripts/webkitpy/tool/comments.py:42 > > + repr = 'r{}'.format(svn_revision) > > + response = requests.get('https://commits.webkit.org/{}/json'.format(repr)) > > + if response.status_code == 200: > > + repr = response.json().get('identifier', repr) > > + return 'Committed r{} ({}): <{}>'.format(svn_revision, repr if '@' in repr else '?', urls.view_identifier_url(repr)) > > Should we consider using svn.webkit.org as a fallback just in case the > former is down? It's possible to use svn.webkit.org as a fallback, but the failure condition is pretty mild: you end up with this: Committed r1234 (?) <https://commits.webkit.org/r1234> , I feel like defending the failure isn't worth maintaining the defense Committed r275119: <https://commits.webkit.org/r275119> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424406 [details]. |