Bug 223820 – [webkit-patch] Use commit.webkit.org instead of remote SVN to compute identifier

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

Folks have objected to the time it takes to cache remote subversion data required to compute identifiers. Consulting commits.webkit.org will be faster.

[Radar WebKit Bug Importer]

<rdar://problem/75902125>

[Jonathan Bedard]

Created attachment 424406 [details]
Patch

Comment on attachment 424406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424406&action=review

> Tools/Scripts/webkitpy/tool/comments.py:42
> +    repr = 'r{}'.format(svn_revision)
> +    response = requests.get('https://commits.webkit.org/{}/json'.format(repr))
> +    if response.status_code == 200:
> +        repr = response.json().get('identifier', repr)
> +    return 'Committed r{} ({}): <{}>'.format(svn_revision, repr if '@' in repr else '?', urls.view_identifier_url(repr))

Should we consider using svn.webkit.org as a fallback just in case the former is down?

r=me with comment.

[Jonathan Bedard]

(In reply to dewei_zhu from comment #3)
> Comment on attachment 424406 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424406&action=review
> 
> > Tools/Scripts/webkitpy/tool/comments.py:42
> > +    repr = 'r{}'.format(svn_revision)
> > +    response = requests.get('https://commits.webkit.org/{}/json'.format(repr))
> > +    if response.status_code == 200:
> > +        repr = response.json().get('identifier', repr)
> > +    return 'Committed r{} ({}): <{}>'.format(svn_revision, repr if '@' in repr else '?', urls.view_identifier_url(repr))
> 
> Should we consider using svn.webkit.org as a fallback just in case the
> former is down?

It's possible to use svn.webkit.org as a fallback, but the failure condition is pretty mild: you end up with this:
Committed r1234 (?) <https://commits.webkit.org/r1234> , I feel like defending the failure isn't worth maintaining the defense

[EWS]

Committed r275119: <https://commits.webkit.org/r275119>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424406 [details].