Bug 223802

Summary: [Cocoa] Allow HTMLMediaElement preload > "metadata" on iPad by default
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch none

Jer Noble
Reported 2021-03-26 09:55:06 PDT
[Cocoa] Allow HTMLMediaElement preload > "metadata" on iPad by default
Attachments
Patch (1.74 KB, patch)
2021-03-26 09:57 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2021-05-04 09:03 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-03-26 09:57:16 PDT
Created attachment 424368 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-03-29 13:55:17 PDT
<rdar://problem/75971620>
Peng Liu
Comment 3 2021-03-29 13:58:49 PDT
Comment on attachment 424368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424368&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:199 > + _mediaDataLoadsAutomatically = !_allowsInlineMediaPlayback; Not a problem of this patch. I am curious whether we can move this line out of the macro.
Jer Noble
Comment 4 2021-04-13 16:13:03 PDT
<rdar://75302974>
Eric Carlson
Comment 5 2021-04-13 16:13:45 PDT
Comment on attachment 424368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424368&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:199 >> + _mediaDataLoadsAutomatically = !_allowsInlineMediaPlayback; > > Not a problem of this patch. I am curious whether we can move this line out of the macro. Isn't this comparison backwards?
Jer Noble
Comment 6 2021-05-04 09:03:43 PDT
Created attachment 427673 [details] Patch
EWS
Comment 7 2021-05-04 13:27:19 PDT
Committed r276979 (237306@main): <https://commits.webkit.org/237306@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427673 [details].
Note You need to log in before you can comment on or make changes to this bug.