Bug 223765

Summary: Remove 10.13 DEPLOYMENT_TARGETs and SYSTEM_VERSION_PREFIXs
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: New BugsAssignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, eric.carlson, ews-watchlist, graouts, hi, jberlin, keith_miller, kondapallykalyan, mark.lam, mitz, msaboff, saam, thorton, tzagallo
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jessie Berlin 2021-03-25 15:04:25 PDT 
Remove 10.13 DEPLOYMENT_TARGETs and SYSTEM_VERSION_PREFIXs
Comment 1 Jessie Berlin 2021-03-25 15:06:51 PDT 
Created attachment 424286 [details]
Patch
Comment 2 EWS Watchlist 2021-03-25 15:07:40 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Tim Horton 2021-03-25 15:09:03 PDT 
Do you want to remove the ones in WebKitTargetConditionals.xcconfigs too?
Comment 4 Jessie Berlin 2021-03-25 16:02:42 PDT 
(In reply to Tim Horton from comment #3)
> Do you want to remove the ones in WebKitTargetConditionals.xcconfigs too?

Those are actually mostly gone! The ones I left in were for 10.14 to compare against.
Comment 5 Jessie Berlin 2021-03-25 16:45:14 PDT 
Created attachment 424297 [details]
Patch
Comment 6 Alexey Proskuryakov 2021-03-25 16:47:15 PDT 
Unrelated to this patch, but we have a whole lot of places with "TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500" and without 11_0.
Comment 7 Jessie Berlin 2021-03-25 16:52:51 PDT 
(In reply to Alexey Proskuryakov from comment #6)
> Unrelated to this patch, but we have a whole lot of places with
> "TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500" and without 11_0.

I will try to clean this up in subsequent bugs/patches!
Comment 8 Jessie Berlin 2021-03-25 16:56:11 PDT 
<rdar://problem/75861212>
Comment 9 EWS 2021-03-25 17:53:00 PDT 
jberlin@webkit.org does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json.

Rejecting attachment 424297 [details] from commit queue.
Comment 10 EWS 2021-03-25 18:29:24 PDT 
Committed r275070: <https://commits.webkit.org/r275070>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424297 [details].
Comment 11 mitz 2021-03-26 09:35:02 PDT 
(In reply to Jessie Berlin from comment #7)
> (In reply to Alexey Proskuryakov from comment #6)
> > Unrelated to this patch, but we have a whole lot of places with
> > "TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500" and without 11_0.
> 
> I will try to clean this up in subsequent bugs/patches!

Aren’t versions 11 and later covered by

TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER));
TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base:base)0000;

since TARGET_MACOS_LEGACY_VERSION_IDENTIFIER for those versions is empty?