Bug 223764

Summary:

Simplify IPCSemaphore.h

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ggaren, Hironori.Fujii, kkinnunen, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=224223

Attachments:

Description	Flags
Patch	none

Description Myles C. Maxfield 2021-03-25 14:59:52 PDT

Simplify IPCSemaphore.h

Comment 1 Myles C. Maxfield 2021-03-25 15:00:48 PDT

Created attachment 424285 [details]
Patch

Comment 2 Geoffrey Garen 2021-03-29 13:16:50 PDT

Comment on attachment 424285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424285&action=review

> Source/WebKit/Platform/IPC/IPCSemaphore.h:62
> -#if OS(DARWIN)
> -    explicit Semaphore(MachSendRight&&);
> -
>      void signal();
>      void wait();
>      void waitFor(Timeout);
> +
> +    explicit operator bool() const;
> +
> +#if OS(DARWIN)
> +    explicit Semaphore(MachSendRight&&);

Is there a non-Darwin implementation of signal(), wait(), and waitFor()? I don't see one in IPCSemaphore.cpp.

Comment 3 Radar WebKit Bug Importer 2021-04-01 15:00:15 PDT

<rdar://problem/76123506>

Comment 4 Myles C. Maxfield 2021-04-06 10:14:18 PDT


*** This bug has been marked as a duplicate of bug 224014 ***