Bug 223764

Summary: Simplify IPCSemaphore.h
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: fujii.hironori, ggaren, kkinnunen, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224223
Attachments:
Description Flags
Patch none

Myles C. Maxfield
Reported 2021-03-25 14:59:52 PDT
Simplify IPCSemaphore.h
Attachments
Patch (3.06 KB, patch)
2021-03-25 15:00 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-03-25 15:00:48 PDT
Created attachment 424285 [details] Patch
Geoffrey Garen
Comment 2 2021-03-29 13:16:50 PDT
Comment on attachment 424285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424285&action=review > Source/WebKit/Platform/IPC/IPCSemaphore.h:62 > -#if OS(DARWIN) > - explicit Semaphore(MachSendRight&&); > - > void signal(); > void wait(); > void waitFor(Timeout); > + > + explicit operator bool() const; > + > +#if OS(DARWIN) > + explicit Semaphore(MachSendRight&&); Is there a non-Darwin implementation of signal(), wait(), and waitFor()? I don't see one in IPCSemaphore.cpp.
Radar WebKit Bug Importer
Comment 3 2021-04-01 15:00:15 PDT
<rdar://problem/76123506>
Myles C. Maxfield
Comment 4 2021-04-06 10:14:18 PDT
*** This bug has been marked as a duplicate of bug 224014 ***
Note You need to log in before you can comment on or make changes to this bug.