| Summary: | [ Debug wk2 ] ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData) | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Robert Jenner <jenner> | ||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||||||||
| Severity: | Normal | CC: | ap, ayumi_kojima, bfulgham, ehutchison, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=229505 https://bugs.webkit.org/show_bug.cgi?id=229722 |
||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Robert Jenner
2021-03-25 09:47:33 PDT
This test appears to have been flakey crashing for a while. However, it did start to crash with more frequency around r274268. I could not reproduce the failure at Big Sur Debug ToT, so I'm currently working on other methods for reproduction. I cannot reproduce the crash with this test. I tried it up to 10000 iterations, and tried testing it using a test list, and I could not get it to reproduce. Does this reproduce when running with many parallel workers? This tends to make timing issues more reproducible. Updated test expectations to Pass Crash: https://trac.webkit.org/changeset/275051/webkit (In reply to Alexey Proskuryakov from comment #4) > Does this reproduce when running with many parallel workers? This tends to > make timing issues more reproducible. I'm still working a little more on reproduction. So far I have run the test standalone as a -f process, a --child-process=1, and a --child-process=50 and I haven't reproduced the crash. I'm working with a test list currently, and am trying the same process with a test list. I was able to reproduce the crash, but under very specific circumstances. To reproduce the crash, first I checked out revision r275036 locally. I chose that revision specifically because it crashed in the history on that revision. After that, I reproduced the crash at r275036 with a test list. It would not crash when being run standalone. I used the following to reproduce the crash: run-webkit-test --test-list <Path to Test list> --debug --child-process=50 The test list used is attached below. I will note as well, that the test has been flakey crashing for a while, but it did seem to get worse starting at r274268 https://trac.webkit.org/changeset/274268/webkit I'm uncertain if changes there caused this though. Created attachment 424301 [details]
Test list
Attaching test list used to reproduce flakey crash.
Created attachment 424302 [details]
Reproduced crash log
Also attaching the crash log from when I was able to reproduce the crash.
Added Failure back to the test expectations after removing them from the prior update here: https://trac.webkit.org/changeset/275336/webkit security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html appears to be hitting this assertion quite frequently on macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS/r431708-6673/results.html Here are some examples from today: https://ews-build.webkit.org/#/builders/60/builds/6805 https://ews-build.webkit.org/#/builders/60/builds/6801 https://ews-build.webkit.org/#/builders/60/builds/6799 https://ews-build.webkit.org/#/builders/60/builds/6677 We should try to reproduce this crash using a test list to see if we can narrow it down to a particular test. Created attachment 435511 [details]
TestList2
Reproduced test results on BigSur r281020: run-webkit-tests -f --force --debug --iterations 1000 --exit-after-n-crashes-or-timeouts 1 --exit-after-n-failures 1 security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html. Also reproduced on Monterey r281020 using test list: run-webkit-tests --force --debug --child-processes 1 --clobber-old-results --test-list= (TestList2 attached). Both reproductions run multiple times to ensure consistent results. Created attachment 435519 [details] CrashLog from r268268 The attached crash log (CrashLog from r268268) doesn't make sense in the context of this bug. It's not an assertion failure, it's just saying that WebKitTestRunner cannot be run on your machine. Thank you for the feedback! (In reply to Alexey Proskuryakov from comment #16) > The attached crash log (CrashLog from r268268) doesn't make sense in the > context of this bug. It's not an assertion failure, it's just saying that > WebKitTestRunner cannot be run on your machine. The crash has been showing up on macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS as a flaky test. Marked expectation so that it won't show up while investigating on EWS: https://trac.webkit.org/changeset/281138/webkit. Updated expectations to skip the test on all platforms in bug 229505 |