Bug 223747

Summary: Only preheat MTLCopyAllDevices on Mac
Product: WebKit Reporter: Ben Nham <nham>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, ews-watchlist, graouts, kkinnunen, kondapallykalyan, mmaxfield, nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

Description Ben Nham 2021-03-25 08:00:58 PDT
Only preheat MTLCopyAllDevices on Mac
Comment 1 Ben Nham 2021-03-25 08:02:38 PDT
Created attachment 424243 [details]
Patch
Comment 2 Chris Dumez 2021-03-25 08:17:53 PDT
Comment on attachment 424243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424243&action=review

r=me, thanks for fixing.

> Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm:50
> +        adoptNS(MTLCopyAllDevices());

You need a local variable here.
Comment 3 Ben Nham 2021-03-25 08:21:41 PDT
Created attachment 424245 [details]
Patch
Comment 4 Chris Dumez 2021-03-25 09:19:45 PDT
Comment on attachment 424245 [details]
Patch

Clearing flags on attachment: 424245

Committed r275036 (235757@main): <https://commits.webkit.org/235757@main>
Comment 5 Chris Dumez 2021-03-25 09:19:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2021-03-25 09:20:28 PDT
<rdar://problem/75839142>