Bug 223705

Summary: AX: Add functions rectsForTextMarkerRange for testing
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: REOPENED    
Severity: Normal CC: commit-queue, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 223746    
Bug Blocks:    
Attachments:
Description Flags
patch none

chris fleizach
Reported 2021-03-24 11:58:36 PDT
We need to add functions in the test runners for rectsForTextMarkerRange for https://trac.webkit.org/changeset/274826/webkit
Attachments
patch (7.51 KB, patch)
2021-03-24 11:59 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-24 11:58:46 PDT
<rdar://problem/75797361>
chris fleizach
Comment 2 2021-03-24 11:59:22 PDT
Created attachment 424164 [details] patch
alan
Comment 3 2021-03-24 12:42:10 PDT
Comment on attachment 424164 [details] patch Is there a particular pattern in adding/not adding notImplemented()?
chris fleizach
Comment 4 2021-03-24 12:47:22 PDT
(In reply to zalan from comment #3) > Comment on attachment 424164 [details] > patch > > Is there a particular pattern in adding/not adding notImplemented()? It doesn’t really appear to be. I just end up copying what was there before. At this point it seems unlikely these would ever be implemented though
alan
Comment 5 2021-03-24 12:48:10 PDT
(In reply to chris fleizach from comment #4) > (In reply to zalan from comment #3) > > Comment on attachment 424164 [details] > > patch > > > > Is there a particular pattern in adding/not adding notImplemented()? > > It doesn’t really appear to be. I just end up copying what was there before. > At this point it seems unlikely these would ever be implemented though ok, thanks.
EWS
Comment 6 2021-03-24 13:38:02 PDT
Committed r274968: <https://commits.webkit.org/r274968> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424164 [details].
WebKit Commit Bot
Comment 7 2021-03-25 06:40:33 PDT
Re-opened since this is blocked by bug 223746
Note You need to log in before you can comment on or make changes to this bug.