Bug 223705

Summary: AX: Add functions rectsForTextMarkerRange for testing
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 223746    
Bug Blocks:    
Attachments:
Description Flags
patch none

Description chris fleizach 2021-03-24 11:58:36 PDT 
We need to add functions in the test runners for rectsForTextMarkerRange for

https://trac.webkit.org/changeset/274826/webkit
Comment 1 Radar WebKit Bug Importer 2021-03-24 11:58:46 PDT 
<rdar://problem/75797361>
Comment 2 chris fleizach 2021-03-24 11:59:22 PDT 
Created attachment 424164 [details]
patch
Comment 3 zalan 2021-03-24 12:42:10 PDT 
Comment on attachment 424164 [details]
patch

Is there a particular pattern in adding/not adding notImplemented()?
Comment 4 chris fleizach 2021-03-24 12:47:22 PDT 
(In reply to zalan from comment #3)
> Comment on attachment 424164 [details]
> patch
> 
> Is there a particular pattern in adding/not adding notImplemented()?

It doesn’t really appear to be. I just end up copying what was there before. At this point it seems unlikely these would ever be implemented though
Comment 5 zalan 2021-03-24 12:48:10 PDT 
(In reply to chris fleizach from comment #4)
> (In reply to zalan from comment #3)
> > Comment on attachment 424164 [details]
> > patch
> > 
> > Is there a particular pattern in adding/not adding notImplemented()?
> 
> It doesn’t really appear to be. I just end up copying what was there before.
> At this point it seems unlikely these would ever be implemented though
ok, thanks.
Comment 6 EWS 2021-03-24 13:38:02 PDT 
Committed r274968: <https://commits.webkit.org/r274968>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424164 [details].
Comment 7 WebKit Commit Bot 2021-03-25 06:40:33 PDT 
Re-opened since this is blocked by bug 223746