Summary: | [Catalina WK2] 5 media/modern-media-controls/tracks-support tests consistently timing out | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||||||
Component: | Media | Assignee: | Devin Rousso <hi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, eric.carlson, ews-watchlist, glenn, hi, jer.noble, philipj, sergio, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=223239 | ||||||||||||
Attachments: |
|
Description
Ryan Haddad
2021-03-23 21:26:29 PDT
Devin, are these tests supposed to work on Catalina or should they be skipped? Yeah I think these should work in Catalina. I wonder why they're working in Big Sur and not Catalina 🤔 I do see ``` CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'subtitlesMenu.children') ``` in the output, so perhaps adding a ``` -if (subtitlesMenu.children?.length) { +if (subtitlesMenu?.children?.length) { ``` would fix this? Created attachment 424194 [details]
[Patch] test for EWS to tell me what `contextmenu` is
Created attachment 424195 [details]
[Patch] test for EWS to tell me what `contextmenu` is (after removing test expectations)
Created attachment 424197 [details]
[Patch] test for EWS to tell me what `contextmenu` is (after removing test expectations)
This testing patch that I've uploaded suggests that these tests are passing on mac-wk2 (which I believe is Catalina), so I'm not really sure what to do here :/ From looking around this issue seems to only reproduce on the Macmini8,1s on Catalina. locally I can only get a timeout running in wk1 which these tests are not ran on in production. Created attachment 424715 [details]
Patch
Committed r275265: <https://commits.webkit.org/r275265> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424715 [details]. |