Bug 223601

Summary: Enforce notifyd message filtering
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 223653, 223768    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
bfulgham: review+, ews-feeder: commit-queue-
Patch
none
Patch none

Per Arne Vollan
Reported 2021-03-22 14:36:22 PDT
Enforce notifyd message filtering on macOS and iOS.
Attachments
Patch (3.18 KB, patch)
2021-03-22 14:52 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (8.91 KB, patch)
2021-03-25 07:08 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (10.21 KB, patch)
2021-03-25 10:21 PDT, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.25 KB, patch)
2021-03-25 13:08 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (10.28 KB, patch)
2021-03-26 10:32 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-03-22 14:37:02 PDT
<rdar://75098580>
Per Arne Vollan
Comment 2 2021-03-22 14:52:38 PDT
Created attachment 423940 [details] Patch
Brent Fulgham
Comment 3 2021-03-23 11:54:33 PDT
Comment on attachment 423940 [details] Patch r=me
Per Arne Vollan
Comment 4 2021-03-23 12:09:07 PDT
Comment on attachment 423940 [details] Patch Thanks for reviewing!
EWS
Comment 5 2021-03-23 12:18:54 PDT
Committed r274889: <https://commits.webkit.org/r274889> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423940 [details].
WebKit Commit Bot
Comment 6 2021-03-23 13:33:35 PDT
Re-opened since this is blocked by bug 223653
EWS
Comment 7 2021-03-24 06:59:26 PDT
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Per Arne Vollan
Comment 8 2021-03-24 10:58:02 PDT
Re-adding r+ flag, since the same patch was previously approved.
EWS
Comment 9 2021-03-24 11:24:50 PDT
Committed r274952: <https://commits.webkit.org/r274952> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423940 [details].
Per Arne Vollan
Comment 10 2021-03-25 07:08:03 PDT
Reopening to attach new patch.
Per Arne Vollan
Comment 11 2021-03-25 07:08:04 PDT
Created attachment 424241 [details] Patch
Per Arne Vollan
Comment 12 2021-03-25 10:21:31 PDT
Created attachment 424255 [details] Patch
Brent Fulgham
Comment 13 2021-03-25 10:39:30 PDT
Comment on attachment 424255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424255&action=review r=me > Source/WTF/wtf/PlatformEnableCocoa.h:665 > +#if !defined(ENABLE_NOTIFY_FILTERING) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000 Is this needed on Catalyst?
Per Arne Vollan
Comment 14 2021-03-25 13:08:51 PDT
Created attachment 424273 [details] Patch
Per Arne Vollan
Comment 15 2021-03-25 13:21:55 PDT
(In reply to Brent Fulgham from comment #13) > Comment on attachment 424255 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424255&action=review > > r=me > > > Source/WTF/wtf/PlatformEnableCocoa.h:665 > > +#if !defined(ENABLE_NOTIFY_FILTERING) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000 > > Is this needed on Catalyst? I don't believe so, since the filtering is not enabled for Catalyst in the sandbox. Thanks for reviewing!
EWS
Comment 16 2021-03-25 14:23:51 PDT
Committed r275057: <https://commits.webkit.org/r275057> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424273 [details].
WebKit Commit Bot
Comment 17 2021-03-25 15:46:10 PDT
Re-opened since this is blocked by bug 223768
Per Arne Vollan
Comment 18 2021-03-26 10:32:43 PDT
Created attachment 424373 [details] Patch
EWS
Comment 19 2021-03-26 12:26:41 PDT
Committed r275108: <https://commits.webkit.org/r275108> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424373 [details].
Note You need to log in before you can comment on or make changes to this bug.