Summary: | Enforce notifyd message filtering | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | benjamin, bfulgham, cdumez, cmarcelo, commit-queue, ews-watchlist, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 223653, 223768 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Per Arne Vollan
2021-03-22 14:36:22 PDT
Created attachment 423940 [details]
Patch
Comment on attachment 423940 [details]
Patch
r=me
Comment on attachment 423940 [details]
Patch
Thanks for reviewing!
Committed r274889: <https://commits.webkit.org/r274889> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423940 [details]. Re-opened since this is blocked by bug 223653 ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Re-adding r+ flag, since the same patch was previously approved. Committed r274952: <https://commits.webkit.org/r274952> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423940 [details]. Reopening to attach new patch. Created attachment 424241 [details]
Patch
Created attachment 424255 [details]
Patch
Comment on attachment 424255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424255&action=review r=me > Source/WTF/wtf/PlatformEnableCocoa.h:665 > +#if !defined(ENABLE_NOTIFY_FILTERING) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000 Is this needed on Catalyst? Created attachment 424273 [details]
Patch
(In reply to Brent Fulgham from comment #13) > Comment on attachment 424255 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424255&action=review > > r=me > > > Source/WTF/wtf/PlatformEnableCocoa.h:665 > > +#if !defined(ENABLE_NOTIFY_FILTERING) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000 > > Is this needed on Catalyst? I don't believe so, since the filtering is not enabled for Catalyst in the sandbox. Thanks for reviewing! Committed r275057: <https://commits.webkit.org/r275057> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424273 [details]. Re-opened since this is blocked by bug 223768 Created attachment 424373 [details]
Patch
Committed r275108: <https://commits.webkit.org/r275108> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424373 [details]. |