Bug 223572

Summary: Move shader info log functionality from ExtensionsGL to GraphicsContextGL
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: dino, kbr, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221664    
Attachments:
Description Flags
Patch kbr: review+

Kimmo Kinnunen
Reported 2021-03-22 05:05:34 PDT
Move shader info log functionality from ExtensionsGL to GraphicsContextGL ExtensionsGL never fulfilled its purpose. Currently it is equivalent to corresponding GraphicsContextGL instance. This just complicates the implementation.
Attachments
Patch (16.27 KB, patch)
2021-03-22 05:17 PDT, Kimmo Kinnunen 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-03-22 05:17:13 PDT
Created attachment 423872 [details] Patch
Kenneth Russell
Comment 2 2021-03-22 16:07:26 PDT
Comment on attachment 423872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423872&action=review One comment about the renaming of this entry point, but r+ once it builds and passes tests. > Source/WebCore/ChangeLog:13 > + WebGL logic, not ANGLE-specific extensions. Not sure I agree with this especially as it will relate to moving more extensions into GraphicsContextGL. glGetTranslatedShaderSourceANGLE is defined in the GL_ANGLE_translated_shader_source extension and it's useful to track where these extension entry points are defined. Also, this is used by the WEBGL_debug_shaders extension (and maybe WebKit's DevTools?) so strictly speaking isn't part of the core WebGL implementation. However, I defer to your judgment on the organization.
Radar WebKit Bug Importer
Comment 3 2021-03-29 09:13:55 PDT
<rdar://problem/75956803>
Kimmo Kinnunen
Comment 4 2022-08-11 00:03:01 PDT
ExtensionsGL was removed in other commit, closing.
Note You need to log in before you can comment on or make changes to this bug.