Bug 223564

Summary: [GPUP] RemoteAudioSession calls into AVAudioSession when GPUP is enabled, causing hangs
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jonlee, peng.liu6, philipj, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 217535    
Bug Blocks:    
Attachments:
Description Flags
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing
ews-feeder: commit-queue-
Patch for landing
ews-feeder: commit-queue-
Patch for landing
ews-feeder: commit-queue-
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

Jer Noble
Reported 2021-03-21 14:14:13 PDT
[GPUP] RemoteAudioSession calls into AVAudioSession when GPUP is enabled, causing hangs
Attachments
Patch (42.71 KB, patch)
2021-03-21 14:20 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (46.95 KB, patch)
2021-03-22 10:08 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (47.13 KB, patch)
2021-05-13 12:35 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (47.17 KB, patch)
2021-05-18 08:55 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (47.22 KB, patch)
2021-05-18 09:18 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (47.23 KB, patch)
2021-05-18 09:31 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-03-21 14:14:35 PDT
<rdar://74750291>
Jer Noble
Comment 2 2021-03-21 14:20:17 PDT
Created attachment 423835 [details] Patch
Eric Carlson
Comment 3 2021-03-21 20:07:26 PDT
Comment on attachment 423835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423835&action=review > Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:102 > - m_interruptionObserverHelper = adoptNS([[WebInterruptionObserverHelper alloc] initWithCallback:session]); > + m_interruptionObserverHelper = [[WebInterruptionObserverHelper alloc] initWithCallback:this]; Did you mean to drop the `adoptNS`?
Jer Noble
Comment 4 2021-03-22 10:08:09 PDT
Created attachment 423903 [details] Patch for landing
Jer Noble
Comment 5 2021-03-23 13:23:53 PDT
The test failures indicate this patch depends on bug #217535.
Jer Noble
Comment 6 2021-05-13 12:35:00 PDT
Created attachment 428545 [details] Patch for landing
EWS
Comment 7 2021-05-17 16:24:09 PDT
Tools/Scripts/svn-apply failed to apply attachment 428545 [details] to trunk. Please resolve the conflicts and upload a new patch.
Jer Noble
Comment 8 2021-05-18 08:55:08 PDT
Created attachment 428943 [details] Patch for landing
Jer Noble
Comment 9 2021-05-18 09:18:10 PDT
Created attachment 428945 [details] Patch for landing
Jer Noble
Comment 10 2021-05-18 09:31:33 PDT
Created attachment 428947 [details] Patch for landing
EWS
Comment 11 2021-05-18 13:59:43 PDT
Committed r277676 (237877@main): <https://commits.webkit.org/237877@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428947 [details].
Note You need to log in before you can comment on or make changes to this bug.