Bug 223526

Summary:

Web Inspector: remove unnecessary inspectorBaseURL() and assumed read access

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, bfulgham, ews-watchlist, ggaren, hi, Hironori.Fujii, inspector-bugzilla-changes, joepeck, pvollan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1.0	hi: review+, ews-feeder: commit-queue-

Description BJ Burg 2021-03-19 11:00:11 PDT

Comment 1 BJ Burg 2021-03-19 11:05:45 PDT

Created attachment 423747 [details]
Patch v1.0

Comment 2 Devin Rousso 2021-03-19 11:23:37 PDT

Comment on attachment 423747 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=423747&action=review

r=me

> Source/WebKit/mac/WebKit2.order:-7829
> -__ZNK6WebKit17WebInspectorProxy16inspectorBaseURLEv

o_0

Is it actually necessary to modify this file anymore?

Comment 3 BJ Burg 2021-03-19 11:23:56 PDT

(In reply to Devin Rousso from comment #2)
> Comment on attachment 423747 [details]
> Patch v1.0
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423747&action=review
> 
> r=me
> 
> > Source/WebKit/mac/WebKit2.order:-7829
> > -__ZNK6WebKit17WebInspectorProxy16inspectorBaseURLEv
> 
> o_0
> 
> Is it actually necessary to modify this file anymore?

Probably not

Comment 4 BJ Burg 2021-03-19 13:20:05 PDT

Committed r274735 (235553@main): <https://commits.webkit.org/235553@main>

Comment 5 Radar WebKit Bug Importer 2021-03-19 13:21:15 PDT

<rdar://problem/75633643>

Comment 6 Fujii Hironori 2021-03-21 21:26:48 PDT

WinCairo is crashing just by openning Web Inspector since r274735.
Filed Bug 223566.