Bug 223499

Summary: libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dino, ews-watchlist, graouts, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Description Alex Christensen 2021-03-18 22:13:17 PDT
libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots
Comment 1 Alex Christensen 2021-03-18 22:15:25 PDT
Created attachment 423692 [details]
Patch
Comment 2 EWS Watchlist 2021-03-18 22:16:33 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Alex Christensen 2021-03-19 11:41:15 PDT
I verified this puts the dylib at /System/iOSSupport/System/Library/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks/libANGLE-shared.dylib in the root.  WebCore roots build to /System/iOSSupport/System/Library/PrivateFrameworks/WebCore.framework so I think that's the right location.
WK_USE_ALTERNATE_FRAMEWORKS_DIR is only YES in iosmac builds because only WK_ALTERNATE_FRAMEWORKS_DIR_iosmac is defined in the ANGLE project, so this shouldn't break anything else.
Comment 4 Alex Christensen 2021-03-19 15:19:26 PDT
r274742
Comment 5 Radar WebKit Bug Importer 2021-03-19 15:20:16 PDT
<rdar://problem/75638888>