Bug 223453

Summary: [ macOS wk2 ARM 64 ] storage/indexeddb/IDBObject-leak.html is a flakey text failure
Product: WebKit Reporter: Robert Jenner <jenner>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, ews-watchlist, jsbell, sihui_liu, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Robert Jenner
Reported 2021-03-18 10:56:04 PDT
storage/indexeddb/IDBObject-leak.html is a flakey text failure in macOS BigSur Release wk2 in Apple Silicon only. HISTORY URL: https://results.webkit.org/?suite=layout-tests&test=storage%2Findexeddb%2FIDBObject-leak.html TEXT DIFF: --- /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk2/build/layout-test-results/storage/indexeddb/IDBObject-leak-expected.txt +++ /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk2/build/layout-test-results/storage/indexeddb/IDBObject-leak-actual.txt @@ -3,8 +3,9 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS internals.numberOfIDBTransactions() is 0 +FAIL internals.numberOfIDBTransactions() should be 0. Was 1. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE
Attachments
Patch (10.62 KB, patch)
2021-04-06 18:18 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (10.83 KB, patch)
2021-07-29 21:24 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (10.38 KB, patch)
2021-07-30 12:39 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (10.46 KB, patch)
2021-07-30 14:45 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (10.48 KB, patch)
2021-07-30 16:14 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-18 10:56:56 PDT
<rdar://problem/75580609>
Robert Jenner
Comment 2 2021-03-18 11:12:09 PDT
Updated test expectations to Pass Failure here: https://trac.webkit.org/changeset/274651/webkit
Robert Jenner
Comment 3 2021-03-18 11:13:24 PDT
The test only appears to be flakey failing on Apple Silicon as of lately. As it is only occurring on Apple Silicon Macs, I cannot reproduce the failure as I do not have access to one.
Sihui Liu
Comment 4 2021-04-06 18:18:39 PDT
Created attachment 425341 [details] Patch
Sihui Liu
Comment 5 2021-07-29 21:24:04 PDT
Created attachment 434602 [details] Patch
youenn fablet
Comment 6 2021-07-30 07:36:37 PDT
Comment on attachment 434602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434602&action=review > LayoutTests/ChangeLog:12 > + IDBTransaction. Do we really need more than one transaction? If we call GC multiple times asynchronously, I would hope one single transaction would be ok. Also, should we make the test stress compatible?
Sihui Liu
Comment 7 2021-07-30 10:31:14 PDT
(In reply to youenn fablet from comment #6) > Comment on attachment 434602 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434602&action=review > > > LayoutTests/ChangeLog:12 > > + IDBTransaction. > > Do we really need more than one transaction? If we call GC multiple times > asynchronously, I would hope one single transaction would be ok. > > Also, should we make the test stress compatible? I will investigate why the stress test fails.
Sihui Liu
Comment 8 2021-07-30 12:39:35 PDT
Created attachment 434652 [details] Patch
Sihui Liu
Comment 9 2021-07-30 14:45:13 PDT
Created attachment 434665 [details] Patch
Sihui Liu
Comment 10 2021-07-30 16:14:28 PDT
Created attachment 434670 [details] Patch
EWS
Comment 11 2021-07-30 23:41:41 PDT
Committed r280510 (240142@main): <https://commits.webkit.org/240142@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434670 [details].
Note You need to log in before you can comment on or make changes to this bug.