| Summary: | [GStreamer][EME] Remove DRM resources release | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||
| Component: | New Bugs | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bandou.yacine, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, olivier.blin, philipj, pnormand, sergio, vjaquez, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Xabier Rodríguez Calvar
2021-03-18 04:05:28 PDT
Created attachment 423582 [details]
Patch
Committed r274719: <https://commits.webkit.org/r274719> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423582 [details]. I think we should let we should have left this "CDMInstanceProxy::releaseDecryptionResources" method, in order to be overloaded when we need release the resources. In some proprietary embedded DRM implementation we need to release some resources in order to be able change the DRM system (like passing from PlayReady to Widevine), and start a new playback, before the javascript GC is performed. For example, in some chipsets, we cannot initialize the TEE for multiple DRM systems at the same time. In this EME test page "https://ytlr-cert.appspot.com/2020/main.html?test_type=encryptedmedia-test" we change from Widevine to Playready." (In reply to Yacine Bandou from comment #5) > we should have left this "CDMInstanceProxy::releaseDecryptionResources" > method, in order to be overloaded when we need release the resources. > > In some proprietary embedded DRM implementation we need to release some > resources > in order to be able change the DRM system (like passing from PlayReady to > Widevine), and start a new playback, before the javascript GC is performed. > > For example, in some chipsets, we cannot initialize the TEE for multiple DRM > systems at the same time. > > In this EME test page > "https://ytlr-cert.appspot.com/2020/main.html?test_type=encryptedmedia-test" > we change from Widevine to Playready." This was used before giving a spin to all session management and it was creating crashes with certain assets. For now, we don't see that necessary. I think you can keep that downstream if you don't find any other way. |