Bug 223421

Summary:

should always use all prerequisites for the `ModernMediaControls.{js,css}` rules in DerivedSources.make

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

New Bugs

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hi, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

223309, 223410

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Description Devin Rousso 2021-03-18 00:51:05 PDT

`$?` is a uniqued space-separated list of all prerequisites modified after the target was modified
`$^` is a uniqued space-separated list of all prerequisites regardless of when the target/prerequisite was modified
We want to use the latter since we always want to `cat` all the JS/CSS files, not just the recently edited ones.

Comment 1 Devin Rousso 2021-03-18 00:51:34 PDT

Created attachment 423566 [details]
Patch

Comment 2 Devin Rousso 2021-03-18 00:53:28 PDT

Created attachment 423567 [details]
Patch

Comment 3 Yusuke Suzuki 2021-03-18 00:57:42 PDT

Comment on attachment 423567 [details]
Patch

Nice, r=me

Comment 4 EWS 2021-03-18 02:11:17 PDT

Committed r274625: <https://commits.webkit.org/r274625>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423567 [details].

Comment 5 Radar WebKit Bug Importer 2021-03-18 02:12:15 PDT

<rdar://problem/75565469>