Bug 223399

Summary: Make fast/images/missing-content-image-crash.html results consistent with internal build
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, mkwst, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2021-03-17 14:03:07 PDT
Make fast/images/missing-content-image-crash.html results consistent with internal build
Attachments
Patch (3.01 KB, patch)
2021-03-17 14:04 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.20 KB, patch)
2021-03-17 16:52 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.55 KB, patch)
2021-03-17 20:08 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-03-17 14:04:08 PDT
Created attachment 423528 [details] Patch
Alex Christensen
Comment 2 2021-03-17 14:04:11 PDT
<rdar://problem/75443811>
Alex Christensen
Comment 3 2021-03-17 16:52:39 PDT
Created attachment 423541 [details] Patch
Alex Christensen
Comment 4 2021-03-17 20:08:35 PDT
Created attachment 423554 [details] Patch
Darin Adler
Comment 5 2021-03-17 21:37:56 PDT
Comment on attachment 423554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423554&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:206 > + "'http://www.webkit.org/path3'," So are we relying on *not* putting www.webkit.org on the list? Seems a little sketchy.
Alex Christensen
Comment 6 2021-03-17 22:05:24 PDT
Comment on attachment 423554 [details] Patch True, but we are relying on a lot of domains in the list in our tests. When/if we add them, we will have similar failing tests internally and we'll do this again.
EWS
Comment 7 2021-03-17 22:30:59 PDT
Committed r274615: <https://commits.webkit.org/r274615> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423554 [details].
Note You need to log in before you can comment on or make changes to this bug.