Bug 223398

Summary:

Reduce maximum HashTable entry size to 250 bytes

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Alex Christensen 2021-03-17 13:40:03 PDT

Reduce maximum HashTable entry size to 250 bytes

Comment 1 Alex Christensen 2021-03-17 13:41:10 PDT

Created attachment 423524 [details]
Patch

Comment 2 Yusuke Suzuki 2021-03-17 16:35:55 PDT

Comment on attachment 423524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423524&action=review

r=me

> Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:74
> +        trackBuffer.get().lastFrameTimescale = 0;
> +        trackBuffer.get().roundedTimestampOffset = MediaTime::invalidTime();

Why not using `->`?

Comment 3 Alex Christensen 2021-03-17 16:45:06 PDT

Comment on attachment 423524 [details]
Patch

They are equivalent but -> looks the same as dereferencing an unchecked pointer if the type were different.  This makes it clearer that null check is needed.

Comment 4 EWS 2021-03-17 17:16:01 PDT

Committed r274603: <https://commits.webkit.org/r274603>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423524 [details].

Comment 5 Radar WebKit Bug Importer 2021-03-17 17:17:15 PDT

<rdar://problem/75551716>