Bug 223397

Summary: [webkitscmpy] Support git-svn in remote mocks
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221860
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2021-03-17 13:37:05 PDT
We should be able to add git-svn tags in BitBucket and GitHub remote mock structures.
Attachments
Patch (11.76 KB, patch)
2021-03-17 13:40 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-17 13:37:18 PDT
<rdar://problem/75541426>
Jonathan Bedard
Comment 2 2021-03-17 13:37:28 PDT
Thought we had this already, apparently we do not.
Jonathan Bedard
Comment 3 2021-03-17 13:40:48 PDT
Created attachment 423523 [details] Patch
Jonathan Bedard
Comment 4 2021-03-17 13:47:24 PDT
Committed r274587 (235428@main): <https://commits.webkit.org/235428@main>
Aakash Jain
Comment 5 2021-03-18 05:21:38 PDT
(In reply to Jonathan Bedard from comment #4) > Committed r274587 (235428@main): <https://commits.webkit.org/235428@main> Seems like it broke resultsdbpy-unit-tests, e.g.: https://ews-build.webkit.org/#/builders/20/builds/42930/steps/14/logs/stdio
Jonathan Bedard
Comment 6 2021-03-22 08:23:49 PDT
(In reply to Aakash Jain from comment #5) > (In reply to Jonathan Bedard from comment #4) > > Committed r274587 (235428@main): <https://commits.webkit.org/235428@main> > Seems like it broke resultsdbpy-unit-tests, e.g.: > https://ews-build.webkit.org/#/builders/20/builds/42930/steps/14/logs/stdio Yes, https://bugs.webkit.org/show_bug.cgi?id=223261 fixes that (although does many other things as well)
Aakash Jain
Comment 7 2021-03-26 11:45:03 PDT
(In reply to Jonathan Bedard from comment #6) > (In reply to Aakash Jain from comment #5) > > (In reply to Jonathan Bedard from comment #4) > > > Committed r274587 (235428@main): <https://commits.webkit.org/235428@main> > > Seems like it broke resultsdbpy-unit-tests, e.g.: > > https://ews-build.webkit.org/#/builders/20/builds/42930/steps/14/logs/stdio > > Yes, https://bugs.webkit.org/show_bug.cgi?id=223261 fixes that (although > does many other things as well) Can we fix the tests in a separate bug and land it soon.
Note You need to log in before you can comment on or make changes to this bug.