Bug 223390

Summary: don't use raw unicode characters in modern media controls JS
Product: WebKit Reporter: Devin Rousso <hi>
Component: MediaAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hi, jer.noble, joepeck, philipj, sergio, simon.fraser, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2021-03-17 11:40:26 PDT
this causes JSC to evaluate the script as UTF-16
Attachments
Patch (7.15 KB, patch)
2021-03-17 11:41 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-03-17 11:41:31 PDT
Created attachment 423511 [details] Patch
EWS
Comment 2 2021-03-17 12:22:26 PDT
Committed r274578: <https://commits.webkit.org/r274578> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423511 [details].
Radar WebKit Bug Importer
Comment 3 2021-03-17 12:23:13 PDT
<rdar://problem/75538232>
Simon Fraser (smfr)
Comment 4 2021-03-17 12:26:37 PDT
Comment on attachment 423511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423511&action=review > Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + * Modules/modern-media-controls/controls/icon-service.js: Missing the "why".
Note You need to log in before you can comment on or make changes to this bug.