Bug 223389

Summary: Add logging to FullscreenManager.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, esprehn+autocc, ews-watchlist, kangil.han, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing none

Description Jer Noble 2021-03-17 11:16:40 PDT 
Add logging to FullscreenManager.
Comment 1 Jer Noble 2021-03-17 11:18:50 PDT 
Created attachment 423506 [details]
Patch
Comment 2 Eric Carlson 2021-03-17 11:22:46 PDT 
Comment on attachment 423506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423506&action=review

> Source/WebCore/dom/FullscreenManager.cpp:50
> +static const char* logClassName() { return "FullscreenManager"; }
> +static WTFLogChannel& logChannel() { return LogFullscreen; }

As we discussed, this is foot gun with the unified build system.
Comment 3 Jer Noble 2021-03-17 11:30:02 PDT 
Created attachment 423508 [details]
Patch for landing
Comment 4 EWS 2021-03-17 14:12:08 PDT 
Committed r274588: <https://commits.webkit.org/r274588>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423508 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-17 14:13:16 PDT 
<rdar://problem/75543298>