Bug 223389

Summary: Add logging to FullscreenManager.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, esprehn+autocc, ews-watchlist, kangil.han, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing none

Jer Noble
Reported 2021-03-17 11:16:40 PDT
Add logging to FullscreenManager.
Attachments
Patch (16.12 KB, patch)
2021-03-17 11:18 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (16.41 KB, patch)
2021-03-17 11:30 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-03-17 11:18:50 PDT
Created attachment 423506 [details] Patch
Eric Carlson
Comment 2 2021-03-17 11:22:46 PDT
Comment on attachment 423506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423506&action=review > Source/WebCore/dom/FullscreenManager.cpp:50 > +static const char* logClassName() { return "FullscreenManager"; } > +static WTFLogChannel& logChannel() { return LogFullscreen; } As we discussed, this is foot gun with the unified build system.
Jer Noble
Comment 3 2021-03-17 11:30:02 PDT
Created attachment 423508 [details] Patch for landing
EWS
Comment 4 2021-03-17 14:12:08 PDT
Committed r274588: <https://commits.webkit.org/r274588> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423508 [details].
Radar WebKit Bug Importer
Comment 5 2021-03-17 14:13:16 PDT
<rdar://problem/75543298>
Note You need to log in before you can comment on or make changes to this bug.