Bug 223340

Summary:

[GTK][WPE][CMake] libCMS2 should be included only if guard USE_LCMS is defined

Product:

WebKit

Reporter:

Diego Pino <dpino>

Component:

New Bugs

Assignee:

Diego Pino <dpino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, bugs-noreply, cgarcia, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=223442

Attachments:

Description	Flags
Patch	none

Diego Pino

Reported 2021-03-17 00:28:29 PDT

[GTK][WPE][CMake] libCMS2 should be included only if guard USE_LCMS is defined

Attachments
Patch (3.00 KB, patch) 2021-03-17 00:29 PDT, Diego Pino	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Diego Pino

Comment 1 2021-03-17 00:29:11 PDT

Created attachment 423443 [details] Patch

Carlos Garcia Campos

Comment 2 2021-03-17 02:18:34 PDT

Why? aren't those just empty?

Diego Pino

Comment 3 2021-03-17 17:49:04 PDT

(In reply to Carlos Garcia Campos from comment #2) > Why? aren't those just empty? In the webkitsearch instance I build WebKit directly using cmake, with a command like this: cmake /home/buildbot/webkit-index/webkit/WebKit -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ '-DCMAKE_C_FLAGS=-Xclang -load -Xclang /home/buildbot/mozsearch/clang-plugin/libclang-index-plugin.so -Xclang -add-plugin -Xclang mozsearch-index -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/analysis -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit/target -Xclang -fparse-all-comments' '-DCMAKE_CXX_FLAGS=-Xclang -load -Xclang /home/buildbot/mozsearch/clang-plugin/libclang-index-plugin.so -Xclang -add-plugin -Xclang mozsearch-index -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/analysis -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit/target -Xclang -fparse-all-comments' -DUSE_WPE_RENDERER=OFF -DUSE_LCMS=OFF -DENABLE_BUBBLEWRAP_SANDBOX=OFF -DENABLE_GAMEPAD=OFF -DCMAKE_BUILD_TYPE=Debug -DPORT=GTK I got the following error when passing -DUSE_LCMS=OFF: CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: LCMS2_INCLUDE_DIR (ADVANCED) used as include directory in directory /home/buildbot/webkit-index/webkit/WebKit/Source/WebCore ... LCMS2_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/buildbot/webkit-index/webkit/WebKit/Source/WebCore ...

EWS

Comment 4 2021-03-18 16:38:20 PDT

Committed r274685: <https://commits.webkit.org/r274685> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423443 [details].

Radar WebKit Bug Importer

Comment 5 2021-03-18 16:39:18 PDT

<rdar://problem/75596979>

Note You need to log in before you can comment on or make changes to this bug.