Bug 223300

Summary: Use ASCIILiteral over String for CSSValue::separatorCSSText() to avoid allocation
Product: WebKit Reporter: Tyler Wilcock <twilco.o>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223205
Attachments:
Description Flags
Patch
none
Patch none

Description Tyler Wilcock 2021-03-16 20:06:20 PDT 
See Darin's comment in this bug:

https://bugs.webkit.org/show_bug.cgi?id=223205#c8
Comment 1 Tyler Wilcock 2021-03-16 20:12:33 PDT 
Created attachment 423426 [details]
Patch
Comment 2 Yusuke Suzuki 2021-03-16 20:31:54 PDT 
Comment on attachment 423426 [details]
Patch

r=me
Comment 3 EWS 2021-03-16 23:36:28 PDT 
commit-queue failed to commit attachment 423426 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 4 Tyler Wilcock 2021-03-17 07:40:04 PDT 
Created attachment 423485 [details]
Patch
Comment 5 Tyler Wilcock 2021-03-17 09:51:03 PDT 
OK, uploaded a new patch with a rebased changelog and another cq?
Comment 6 Darin Adler 2021-03-17 10:05:08 PDT 
Comment on attachment 423485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423485&action=review

> Source/WebCore/css/CSSValue.h:30
> +#include <wtf/text/ASCIILiteral.h>

A forward declaration of ASCIILiteral should be added to Forward.h. Then we could remove this include. Not critical to do right now, of course.
Comment 7 EWS 2021-03-17 10:22:48 PDT 
Committed r274566: <https://commits.webkit.org/r274566>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423485 [details].
Comment 8 Radar WebKit Bug Importer 2021-03-17 10:23:15 PDT 
<rdar://problem/75532517>