| Summary: | [Swift] Ambiguous use of 'closeAllMediaPresentations' | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||
| Component: | New Bugs | Assignee: | Kate Cheney <katherine_cheney> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, james.savage, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Kate Cheney
2021-03-16 12:58:42 PDT
Created attachment 423384 [details]
Patch
Comment on attachment 423384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423384&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:3342 > +#ifndef __swift__ I'd drop this from the implementation. It will never be the case that __swift__ is defined for this compilation unit, so it just adds confusion about whether this bit of code is actually conditional or not. The issue here is just about how the interface is perceived by the Swift compiler, so all that's need are the changes in the header. Created attachment 423389 [details]
Patch
Committed r274516: <https://commits.webkit.org/r274516> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423389 [details]. |