Bug 223275

Summary: [Swift] Ambiguous use of 'closeAllMediaPresentations'
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, james.savage, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kate Cheney
Reported 2021-03-16 12:58:42 PDT
[Swift] Ambiguous use of 'closeAllMediaPresentations'
Attachments
Patch (3.65 KB, patch)
2021-03-16 12:59 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (2.69 KB, patch)
2021-03-16 13:10 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2021-03-16 12:59:11 PDT
Created attachment 423384 [details] Patch
Kate Cheney
Comment 2 2021-03-16 12:59:14 PDT
<rdar://problem/75447989>
James Savage
Comment 3 2021-03-16 13:06:22 PDT
Comment on attachment 423384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423384&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:3342 > +#ifndef __swift__ I'd drop this from the implementation. It will never be the case that __swift__ is defined for this compilation unit, so it just adds confusion about whether this bit of code is actually conditional or not. The issue here is just about how the interface is perceived by the Swift compiler, so all that's need are the changes in the header.
Kate Cheney
Comment 4 2021-03-16 13:10:18 PDT
Created attachment 423389 [details] Patch
EWS
Comment 5 2021-03-16 14:17:58 PDT
Committed r274516: <https://commits.webkit.org/r274516> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423389 [details].
Note You need to log in before you can comment on or make changes to this bug.