Bug 223275

Summary: [Swift] Ambiguous use of 'closeAllMediaPresentations'
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Severity: Normal CC: achristensen, james.savage, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Kate Cheney 2021-03-16 12:58:42 PDT
[Swift] Ambiguous use of 'closeAllMediaPresentations'
Comment 1 Kate Cheney 2021-03-16 12:59:11 PDT
Created attachment 423384 [details]
Comment 2 Kate Cheney 2021-03-16 12:59:14 PDT
Comment 3 James Savage 2021-03-16 13:06:22 PDT
Comment on attachment 423384 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=423384&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:3342
> +#ifndef __swift__

I'd drop this from the implementation. It will never be the case that __swift__ is defined for this compilation unit, so it just adds confusion about whether this bit of code is actually conditional or not.
The issue here is just about how the interface is perceived by the Swift compiler, so all that's need are the changes in the header.
Comment 4 Kate Cheney 2021-03-16 13:10:18 PDT
Created attachment 423389 [details]
Comment 5 EWS 2021-03-16 14:17:58 PDT
Committed r274516: <https://commits.webkit.org/r274516>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423389 [details].