Bug 223267

Summary:

Web Automation: Web Share menu being open causes hang in `Automation.isShowingJavaScriptDialog`

Product:

WebKit

Reporter:

Patrick Angle <pangle>

Component:

Web Inspector

Assignee:

Patrick Angle <pangle>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, inspector-bugzilla-changes, pangle, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1.0	none

Description Patrick Angle 2021-03-16 11:46:22 PDT

Comment 1 Patrick Angle 2021-03-16 11:46:49 PDT

<rdar://74197601>

Comment 2 Patrick Angle 2021-03-16 12:06:07 PDT

Created attachment 423376 [details]
Patch v1.0

Comment 3 BJ Burg 2021-03-16 12:08:13 PDT

Comment on attachment 423376 [details]
Patch v1.0

r=me

Comment 4 BJ Burg 2021-03-16 12:55:51 PDT

commit-queue is hitting some tests that flakily time out, but I don't think it's related to this change.

Comment 5 EWS 2021-03-16 13:05:22 PDT

Committed r274509: <https://commits.webkit.org/r274509>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423376 [details].

Comment 6 Patrick Angle 2021-03-16 13:06:15 PDT

(In reply to BJ Burg from comment #4)
> commit-queue is hitting some tests that flakily time out, but I don't think
> it's related to this change.

I agree they appear unrelated, plus I can't see a way that any of these tests could fail based on what this change actually is.

The one test that crashed appears to have a history of doing so as well.