| Summary: | ANGLE Metal fixups for program generation, readPixels | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kyle Piddington <kpiddington> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, ews-watchlist, graouts, kondapallykalyan, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 222239 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Kyle Piddington
2021-03-16 10:17:03 PDT
Created attachment 423353 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 2021-03-16 Kyle Piddington <kpiddington@apple.com> ANGLE Metal fixups for program generation, readPixels https://bugs.webkit.org/show_bug.cgi?id=223260 This diff fixes the following tests: webgl/2.0.0/conformance2/glsl3/texture-offset-uniform-texture-coordinate.html Is fixed by dropping 'thread' qualifiers on our intermediate texture sampling helper functions. Previously, any uniforms used in sampling textures would have had issues with their namespace. webgl/2.0.0/conformance2/reading/read-pixels-pack-parameters.html is fixed by correcting an issue with reading from outside the framebuffer. ANGLE Metal was previously reading to the start of the output array, rather than a proper offset. webgl/2.0.0/conformance2/glsl3/array-equality.html is fixed by adding additional equality functions for handling arrays of structs. Reviewed by NOBODY (OOPS!). * src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp: (GetOperatorString): * src/compiler/translator/TranslatorMetalDirect/ProgramPrelude.cpp: * src/libANGLE/renderer/metal/FrameBufferMtl.mm: (rx::FramebufferMtl::readPixels): Comment on attachment 423353 [details]
Patch
You're missing a changelog.
Created attachment 423501 [details]
Patch
Created attachment 423502 [details]
Patch
Committed r274585 (235426@main): <https://commits.webkit.org/235426@main> |