Bug 223235

Summary: [git-webkit] Showing help instead of raising an exception with no command
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryosuke Niwa
Reported 2021-03-15 20:46:45 PDT
Instead of raising an exception, show the help when there is no command specified. % ./Tools/Scripts/git-webkit Traceback (most recent call last): File "./Tools/Scripts/git-webkit", line 45, in <module> sys.exit(program.main( File "./Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 76, in main return parsed.main( AttributeError: 'Namespace' object has no attribute 'main'
Attachments
Patch (2.52 KB, patch)
2021-03-16 09:50 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-16 09:47:27 PDT
<rdar://problem/75480951>
Jonathan Bedard
Comment 2 2021-03-16 09:47:42 PDT
Just an overbite that this isn't the case now.
Jonathan Bedard
Comment 3 2021-03-16 09:50:27 PDT
Created attachment 423343 [details] Patch
Jonathan Bedard
Comment 4 2021-03-16 10:01:32 PDT
(In reply to Jonathan Bedard from comment #2) > Just an overbite that this isn't the case now. *oversite
EWS
Comment 5 2021-03-16 13:51:14 PDT
Committed r274512: <https://commits.webkit.org/r274512> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423343 [details].
Note You need to log in before you can comment on or make changes to this bug.