| Summary: | RunLoop::isMain() should not need to do any heap allocations | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, ap, benjamin, cmarcelo, darin, ews-watchlist, ggaren, sam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 223226 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2021-03-15 17:20:54 PDT
Created attachment 423268 [details]
Patch
Committed r274458: <https://commits.webkit.org/r274458> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423268 [details]. Comment on attachment 423268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423268&action=review > Source/WTF/wtf/RunLoop.cpp:65 > +auto RunLoop::runLoopHolder() -> ThreadSpecific<Holder>& Is this style better? (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 423268 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423268&action=review > > > Source/WTF/wtf/RunLoop.cpp:65 > > +auto RunLoop::runLoopHolder() -> ThreadSpecific<Holder>& > > Is this style better? I use it whenever it makes the type shorter. I would have needed to use 'ThreadSpecific<RunLoop::Holder>&' otherwise. I don't think we have a style rule either way but I have seen other people (including Darin) use it in such cases. (In reply to Chris Dumez from comment #5) > I use it whenever it makes the type shorter. Yes, I do it whenever it makes the type significantly shorter. |