Bug 223225

Summary: [prepare-ChangeLog] Assigning a multiline comment to a variable breaks change detection
Product: WebKit Reporter: Dean Johnson <dean_johnson>
Component: Tools / TestsAssignee: Dean Johnson <dean_johnson>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dean_johnson, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fix-multiline-string-variable-definition_v1 none

Description Dean Johnson 2021-03-15 17:19:42 PDT 
As of bug 182405 / http://trac.webkit.org/changeset/228131/webkit, prepare-ChangeLog fails to correctly detect changes to a Python file when a multiline comment is defined and assigned to a variable.

Failure case:
TABLE_CSS_STYLING = '''
<style>
...  (Unimportant) ...
</style>
'''

Changing the TABLE_CSS_STYLING definition makes prepare-ChangeLog work again:
TABLE_CSS_STYLING = \
'''
<style>
...  (Unimportant) ...
</style>
'''

prepare-ChangeLog should support multiline string assignment on the same line.
Comment 1 Dean Johnson 2021-03-15 17:37:01 PDT 
Created attachment 423273 [details]
fix-multiline-string-variable-definition_v1
Comment 2 EWS 2021-03-16 09:06:01 PDT 
Committed r274481: <https://commits.webkit.org/r274481>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423273 [details].
Comment 3 Radar WebKit Bug Importer 2021-03-16 09:07:18 PDT 
<rdar://problem/75479145>