Bug 223220

Summary:

[Multi-column] Ignore line grid offset when the grid line is shorter than 0.5px

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2021-03-15 15:31:29 PDT

<rdar://73192773>

Comment 1 zalan 2021-03-15 16:05:44 PDT

Created attachment 423258 [details]
Patch

Comment 2 Simon Fraser (smfr) 2021-03-15 16:11:40 PDT

Comment on attachment 423258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423258&action=review

> Source/WebCore/rendering/RenderLayoutState.cpp:205
> +    if (!roundToInt(lineGridBox->lineBoxHeight()))

Maybe store lineBoxHeight in a local variable since this code now calls it three times.

Comment 3 zalan 2021-03-15 16:16:56 PDT

Created attachment 423259 [details]
Patch

Comment 4 EWS 2021-03-15 17:52:11 PDT

Committed r274456: <https://commits.webkit.org/r274456>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423259 [details].