Bug 223219

Summary: [WebIDL] Optimize convertRecord() to avoid double |key| lookup
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: BindingsAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Enhancement CC: achristensen, cdumez, darin, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223231
Attachments:
Description Flags
Patch
none
Microbenchmark none

Alexey Shvayka
Reported 2021-03-15 15:18:38 PDT
[WebIDL] Optimize convertRecord() to avoid double |key| lookup
Attachments
Patch (4.46 KB, patch)
2021-03-15 15:24 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Microbenchmark (639 bytes, text/html)
2021-03-16 09:47 PDT, Alexey Shvayka 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2021-03-15 15:24:12 PDT
Created attachment 423253 [details] Patch
Alexey Shvayka
Comment 2 2021-03-16 09:47:42 PDT
Created attachment 423342 [details] Microbenchmark 10 keys / 10k runs / 1s interval Trunk: 26.5ms Patch: 21.2ms (20% faster)
Alexey Shvayka
Comment 3 2021-03-16 15:27:33 PDT
Comment on attachment 423253 [details] Patch Windows EWS failures are unrelated. cq+
EWS
Comment 4 2021-03-16 16:02:29 PDT
Committed r274529: <https://commits.webkit.org/r274529> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423253 [details].
Radar WebKit Bug Importer
Comment 5 2021-03-16 16:03:18 PDT
<rdar://problem/75499121>
Note You need to log in before you can comment on or make changes to this bug.