Bug 223218

Summary: [WK2] Can get stuck in fullscreen mode if node is removed prior to receiving willEnterFullscreen()
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, esprehn+autocc, ews-watchlist, kangil.han, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing
none
Patch for landing none

Description Jer Noble 2021-03-15 15:14:49 PDT 
[WK2] Can get stuck in fullscreen mode if node is removed prior to receiving willEnterFullscreen()
Comment 1 Jer Noble 2021-03-15 15:15:47 PDT 
<rdar://75009548>
Comment 2 Jer Noble 2021-03-15 15:19:51 PDT 
Created attachment 423252 [details]
Patch
Comment 3 Eric Carlson 2021-03-15 16:06:39 PDT 
Comment on attachment 423252 [details]
Patch

r=me once the bots are happy
Comment 4 Peng Liu 2021-03-15 16:18:08 PDT 
Comment on attachment 423252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423252&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenRemoveNodeBeforeEnter.mm:30
> +// Enable theis test on iOS once that issue is resolved.

Nit. s/theis/this/g
Comment 5 Jer Noble 2021-03-15 17:34:34 PDT 
Created attachment 423271 [details]
Patch for landing
Comment 6 Jer Noble 2021-03-15 17:36:01 PDT 
Created attachment 423272 [details]
Patch for landing
Comment 7 EWS 2021-03-15 20:03:29 PDT 
Committed r274460: <https://commits.webkit.org/r274460>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423272 [details].