Bug 223209

Summary:

Web Inspector: remove experimental setting and enable "grid" badges

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

221246

Bug Blocks:

Attachments:

Description	Flags
Patch	bburg: review+, bburg: commit-queue-
Patch	none

Description Nikita Vasilyev 2021-03-15 12:44:11 PDT

"grid" badges are ready to be enabled by default.

Comment 1 Radar WebKit Bug Importer 2021-03-15 12:44:20 PDT

<rdar://problem/75442185>

Comment 2 Nikita Vasilyev 2021-03-15 12:51:58 PDT

Created attachment 423225 [details]
Patch

Comment 3 BJ Burg 2021-03-15 14:00:14 PDT

Comment on attachment 423225 [details]
Patch

r=me but please rebase and send to EWS

Comment 4 Nikita Vasilyev 2021-03-16 09:07:37 PDT

I'm going to add a backend command check here as well.

Comment 5 Nikita Vasilyev 2021-03-16 10:00:42 PDT

(In reply to Nikita Vasilyev from comment #4)
> I'm going to add a backend command check here as well.

Actually, this isn't necessary. There's already check for `layoutContextType !== WI.DOMNode.LayoutContextType.Grid` that prevents showing the grid badges when the backend end is old.

Comment 6 Nikita Vasilyev 2021-03-16 10:02:14 PDT

Created attachment 423348 [details]
Patch

Comment 7 Nikita Vasilyev 2021-03-17 11:26:28 PDT

Comment on attachment 423348 [details]
Patch

Unrelated test failure in http/tests/css/filters-on-iframes-transform.html.

Comment 8 EWS 2021-03-17 11:56:36 PDT

Committed r274575: <https://commits.webkit.org/r274575>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423348 [details].