Bug 223207

Summary: [iOS] WebPageProxy's EditorState may be stale until the next remote layer tree commit
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For EWS ews-feeder: commit-queue-

Description Wenson Hsieh 2021-03-15 12:26:42 PDT 
<rdar://problem/75410700>
Comment 1 Wenson Hsieh 2021-03-15 13:19:09 PDT 
Created attachment 423228 [details]
Patch
Comment 2 Tim Horton 2021-03-15 13:28:17 PDT 
Comment on attachment 423228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423228&action=review

> Source/WebKit/ChangeLog:3
> +        Refactor some codepaths for updating EditorState in the UI process

Is it possible for this to state the problem instead of the solution?

> Source/WebKit/ChangeLog:20
> +        3.  The pending `BackingStoreFlusher` created in step (1) dispatches on the background queue, and sends its
> +            editor state over to the UI process.

Oh no
Comment 3 Wenson Hsieh 2021-03-15 13:35:28 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 423228 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423228&action=review
> 
> > Source/WebKit/ChangeLog:3
> > +        Refactor some codepaths for updating EditorState in the UI process
> 
> Is it possible for this to state the problem instead of the solution?

Good point! Retitling the bug...

> 
> > Source/WebKit/ChangeLog:20
> > +        3.  The pending `BackingStoreFlusher` created in step (1) dispatches on the background queue, and sends its
> > +            editor state over to the UI process.
> 
> Oh no

Quite 😬
Comment 4 Wenson Hsieh 2021-03-15 14:24:38 PDT 
Created attachment 423239 [details]
For EWS
Comment 5 EWS 2021-03-15 18:25:47 PDT 
Committed r274457: <https://commits.webkit.org/r274457>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423239 [details].