Bug 223158

Summary:

[JSC] Run one Mozilla test explicitly under PST since this test does not work when we are moving from PST to PDT

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

REOPENED

Severity:

Normal

CC:

commit-queue, mark.lam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

223187

Bug Blocks:

Attachments:

Description	Flags
Patch	mark.lam: review+

Yusuke Suzuki

Reported 2021-03-14 00:58:00 PST

[JSC] Run one Mozilla test explicitly under PST since this test does not work when we are moving from PST to DST

Attachments
Patch (31.16 KB, patch) 2021-03-14 00:59 PST, Yusuke Suzuki	mark.lam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2021-03-14 00:59:43 PST

Created attachment 423120 [details] Patch

Mark Lam

Comment 2 2021-03-14 09:36:11 PDT

Comment on attachment 423120 [details] Patch r=me Thanks for fixing this. This bug has been present going back at least 8 years. For 2 hours a year when we switch daylight savings time, this test would always fail. I see that the real change that matters is that you specified "TZ=PST" and use runComplexTest to get it applied to the environment. However, I wasn't able to tease out where our system picks up this env var. Would you mind pointing me to it for future reference?

Yusuke Suzuki

Comment 3 2021-03-14 15:08:40 PDT

(In reply to Mark Lam from comment #2) > Comment on attachment 423120 [details] > Patch > > r=me > > Thanks for fixing this. This bug has been present going back at least 8 > years. For 2 hours a year when we switch daylight savings time, this test > would always fail. > > I see that the real change that matters is that you specified "TZ=PST" and > use runComplexTest to get it applied to the environment. However, I wasn't > able to tease out where our system picks up this env var. Would you mind > pointing me to it for future reference? This is ICU. "TZ" environment variable is recognized by ICU, and we use it for ICU date times. And JSC's date implementation is using ICU.

Yusuke Suzuki

Comment 4 2021-03-14 15:14:11 PDT

Committed r274405 (235272@main): <https://commits.webkit.org/235272@main>

Radar WebKit Bug Importer

Comment 5 2021-03-14 15:15:16 PDT

<rdar://problem/75412033>

WebKit Commit Bot

Comment 6 2021-03-15 09:39:35 PDT

Re-opened since this is blocked by bug 223187

Note You need to log in before you can comment on or make changes to this bug.