| Summary: | [JSC] Run one Mozilla test explicitly under PST since this test does not work when we are moving from PST to PDT | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | REOPENED --- | ||||||
| Severity: | Normal | CC: | commit-queue, mark.lam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 223187 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2021-03-14 00:58:00 PST
Created attachment 423120 [details]
Patch
Comment on attachment 423120 [details]
Patch
r=me
Thanks for fixing this. This bug has been present going back at least 8 years. For 2 hours a year when we switch daylight savings time, this test would always fail.
I see that the real change that matters is that you specified "TZ=PST" and use runComplexTest to get it applied to the environment. However, I wasn't able to tease out where our system picks up this env var. Would you mind pointing me to it for future reference?
(In reply to Mark Lam from comment #2) > Comment on attachment 423120 [details] > Patch > > r=me > > Thanks for fixing this. This bug has been present going back at least 8 > years. For 2 hours a year when we switch daylight savings time, this test > would always fail. > > I see that the real change that matters is that you specified "TZ=PST" and > use runComplexTest to get it applied to the environment. However, I wasn't > able to tease out where our system picks up this env var. Would you mind > pointing me to it for future reference? This is ICU. "TZ" environment variable is recognized by ICU, and we use it for ICU date times. And JSC's date implementation is using ICU. Committed r274405 (235272@main): <https://commits.webkit.org/235272@main> Re-opened since this is blocked by bug 223187 |