Summary: | REGRESSION(r274270): [WPE][GTK] Broke Epiphany test /embed/ephy-web-view/error-pages-not-stored-in-history | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||
Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, berto, bugs-noreply, cgarcia, darin, ews-watchlist, gustavo, mcatanzaro | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=222943 | ||||||||
Attachments: |
|
Description
Michael Catanzaro
2021-03-12 14:10:16 PST
Actually, to be very conservative, I'll change it to return empty string only if both protocol and host are empty, OK? Created attachment 423081 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 423081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423081&action=review > Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:136 > +static void testBogusPort(Test*, gconstpointer) > +{ > + // Garbage in, garbage out... > + WebKitSecurityOrigin* origin = webkit_security_origin_new("http", "localhost", 9999); That's... not a bogus port. I'll fix that before landing. Created attachment 423088 [details]
Patch for landing
Committed r274375: <https://commits.webkit.org/r274375> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423088 [details]. Comment on attachment 423088 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=423088&action=review > Source/WebCore/page/SecurityOriginData.cpp:45 > + if (protocol.isEmpty() && host.isEmpty()) > + return { }; This is a cross-platform change. It’s good we have regression tests for this for [glib]. Is there also a way we can make a cross-platform test for it? It could probably be done using WKSecurityOriginCreate. I think this change is good cross-platform. We certainly don't want "://" to be the origin. We have a test WKSecurityOrigin.cpp already that's designed to be cross-platform, but it's not listed in any CMake file, so it's really XCode-specific unfortunately.... |