Summary: | postprocess-asm/resolve-asm-file-conflicts.rb build failure after upgrading to F34 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||
Component: | JavaScriptCore | Assignee: | Angelos Oikonomopoulos <angelos> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | angelos, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=229491 | ||||||||
Attachments: |
|
Description
Michael Catanzaro
2021-03-12 12:51:45 PST
Thanks for looking into this! Judging by the error message, I guess the version of gcc on fedora-34 changed the way it's generating the .file assembler directives to .file "path/to/dir" "filename" (which I've seen clang use). I'll try to reproduce this in a container so I can test a fix. (In reply to Angelos Oikonomopoulos from comment #1) [...] > I'll try to reproduce this in a container so I can test a fix. Strange, I can't reproduce this in a F34 container. Using gcc-11.0.0-0.20.fc34.x86_64 gcc-c++-11.0.0-0.20.fc34.x86_64 and ./Tools/Scripts/build-jsc --jsc-only --debug I have the same version of GCC. Is there some generated output I should give to help debug? For what it's worth: builds are succeeding on koji, so there must be some sort of difference between my system vs. the container.... (In reply to Michael Catanzaro from comment #3) > I have the same version of GCC. Is there some generated output I should give > to help debug? > > For what it's worth: builds are succeeding on koji, so there must be some > sort of difference between my system vs. the container.... Odd. Would love to hear more if you find out what the difference is. Having LowLevelInterpreter.cpp.pre.s (alternatively, all .file directives from it) should be enough to be able to test a fix. (In reply to Angelos Oikonomopoulos from comment #4) > Having LowLevelInterpreter.cpp.pre.s (alternatively, all .file directives > from it) should be enough to be able to test a fix. You probably need to temporarily comment out the call to File.delete(p) towards the end of postprocess-asm to preserve that file. Created attachment 423173 [details]
LowLevelInterpreter.cpp.pre.s
Looks like the problem is here: .Ldebug_line0: .file 0 "/home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME" "../../Source/JavaScriptCore/llint/LowLevelInterpreter.cpp" .section .debug_str,"MS",@progbits,1 Two strings on the same line. That seems to be the only place in the file where this happens. Created attachment 423180 [details]
Patch
Does this patch fix it? Comment on attachment 423180 [details]
Patch
That works, thanks!
Committed r274428: <https://commits.webkit.org/r274428> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423180 [details]. |