Bug 223134

Summary: REGRESSION (r274308): Two assertions in JSGlobalObject::defineOwnProperty() are failing
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Normal CC: amir_mark, ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203456
Attachments:
Description Flags
REVERT of r274308
none
Patch ysuzuki: review+, ews-feeder: commit-queue-

Description WebKit Commit Bot 2021-03-12 12:48:07 PST 
https://trac.webkit.org/changeset/274308 broke the build:
Caused assertion failure with JSC tests

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2021-03-12 12:48:18 PST 
Created attachment 423074 [details]
REVERT of r274308

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 EWS 2021-03-12 12:52:06 PST 
commit-queue failed to commit attachment 423074 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 3 Alexey Shvayka 2021-03-12 14:36:56 PST 
Created attachment 423084 [details]
Patch
Comment 4 Yusuke Suzuki 2021-03-13 17:59:58 PST 
Comment on attachment 423084 [details]
Patch

r=me
Comment 5 Alexey Shvayka 2021-03-14 15:18:48 PDT 
Committed r274406 (235273@main): <https://commits.webkit.org/235273@main>
Comment 6 Radar WebKit Bug Importer 2021-03-14 15:19:14 PDT 
<rdar://problem/75412061>
Comment 7 Alexey Shvayka 2021-03-14 15:20:17 PDT 
(In reply to Yusuke Suzuki from comment #4)
> Comment on attachment 423084 [details]
> Patch
> 
> r=me

Thanks!