Bug 223134

Summary:

REGRESSION (r274308): Two assertions in JSGlobalObject::defineOwnProperty() are failing

Product:

WebKit

Reporter:

WebKit Commit Bot <commit-queue>

Component:

JavaScriptCore

Assignee:

Alexey Shvayka <ashvayka>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

amir_mark, ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=203456

Attachments:

Description	Flags
REVERT of r274308	none
Patch	ysuzuki: review+, ews-feeder: commit-queue-

WebKit Commit Bot

Reported 2021-03-12 12:48:07 PST

https://trac.webkit.org/changeset/274308 broke the build: Caused assertion failure with JSC tests This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.

Attachments
REVERT of r274308 (40.73 KB, patch) 2021-03-12 12:48 PST, WebKit Commit Bot	no flags	Details Formatted Diff Diff
Patch (4.35 KB, patch) 2021-03-12 14:36 PST, Alexey Shvayka	ysuzuki: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

WebKit Commit Bot

Comment 1 2021-03-12 12:48:18 PST

Created attachment 423074 [details] REVERT of r274308 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.

EWS

Comment 2 2021-03-12 12:52:06 PST

commit-queue failed to commit attachment 423074 [details] to WebKit repository. To retry, please set cq+ flag again.

Alexey Shvayka

Comment 3 2021-03-12 14:36:56 PST

Created attachment 423084 [details] Patch

Yusuke Suzuki

Comment 4 2021-03-13 17:59:58 PST

Comment on attachment 423084 [details] Patch r=me

Alexey Shvayka

Comment 5 2021-03-14 15:18:48 PDT

Committed r274406 (235273@main): <https://commits.webkit.org/235273@main>