Summary: | [Win][WK1] Add a new API IWebPreferences::startBatchingUpdates to defer WebPreferencesChangedNotification | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | WebKit Misc. | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, don.olmstead, pvollan, rniwa, sam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=220699 | ||||||||
Attachments: |
|
Description
Fujii Hironori
2021-03-11 20:56:34 PST
See also: Bug 220145 – [Win][DumpRenderTree] Some JS tests are timing out only in Debug builds since r269157 Apple-Win-10-Debug-Tests is broken these days. https://build.webkit.org/#/builders/16 WinCairo buildbot (In reply to Fujii Hironori from comment #0) > the first bad : 235041@main (r274111) https://build.webkit.org/#/builders/32/builds/140 > the last good: 235009@main (r274073) https://build.webkit.org/#/builders/32/builds/139 Mac port has _batchUpdatePreferencesInBlock to defer _postPreferencesChangedNotification. Bug 218024 – Simplify DumpRenderTree WebPreferences reset Created attachment 423134 [details]
Patch
Comment on attachment 423134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423134&action=review > Source/WebKitLegacy/win/WebPreferences.cpp:2641 > + if (m_updateAfterBatch) { I would call this variable m_needsUpdateAfterBatch; in this case. Sorry for breaking this. Created attachment 423138 [details]
Patch for landing
Committed r274407: <https://commits.webkit.org/r274407> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423138 [details]. *** Bug 220699 has been marked as a duplicate of this bug. *** |