Bug 223103

Summary: Derive index EUC-KR from ICU
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ysuzuki: review+, ews-feeder: commit-queue-

Alex Christensen
Reported 2021-03-11 16:38:37 PST
Derive index EUC-KR from ICU
Attachments
Patch (4.01 KB, patch)
2021-03-11 16:40 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2021-03-11 21:40 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.41 KB, patch)
2021-03-12 07:59 PST, Alex Christensen 		ysuzuki: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-03-11 16:40:12 PST
Created attachment 422991 [details] Patch
Alex Christensen
Comment 2 2021-03-11 21:40:52 PST
Created attachment 423014 [details] Patch
Alex Christensen
Comment 3 2021-03-12 07:59:06 PST
Created attachment 423049 [details] Patch
Yusuke Suzuki
Comment 4 2021-03-12 16:22:34 PST
Comment on attachment 423049 [details] Patch r=me
Darin Adler
Comment 5 2021-03-12 17:22:07 PST
Comment on attachment 423049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423049&action=review > Source/WebCore/platform/text/EncodingTables.cpp:8654 > - ASSERT(isSortedByFirst(eucKRDecodingIndex)); > - ASSERT(sortedFirstsAreUnique(eucKRDecodingIndex)); > + ASSERT(isSortedByFirst(eucKR())); > + ASSERT(sortedFirstsAreUnique(eucKR())); Wouldn’t you want to keep both of these?
Alex Christensen
Comment 6 2021-03-12 20:29:29 PST
Comment on attachment 423049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423049&action=review >> Source/WebCore/platform/text/EncodingTables.cpp:8654 >> + ASSERT(sortedFirstsAreUnique(eucKR())); > > Wouldn’t you want to keep both of these? I don't t think I understand this comment. I am keeping both of these
EWS
Comment 7 2021-03-12 20:57:53 PST
commit-queue failed to commit attachment 423049 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 8 2021-03-12 22:09:26 PST
commit-queue failed to commit attachment 423049 [details] to WebKit repository. To retry, please set cq+ flag again.
Darin Adler
Comment 9 2021-03-14 13:20:08 PDT
Comment on attachment 423049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423049&action=review >>> Source/WebCore/platform/text/EncodingTables.cpp:8654 >>> + ASSERT(sortedFirstsAreUnique(eucKR())); >> >> Wouldn’t you want to keep both of these? > > I don't t think I understand this comment. I am keeping both of these I was suggesting we could separately assert both that eucKRDecodingIndexReference is sorted and unique and that the actual generated table is?
Alex Christensen
Comment 10 2021-03-17 10:36:42 PDT
We assert that they are equal when generating the table.
Alex Christensen
Comment 11 2021-03-17 10:38:04 PDT
r274569
Darin Adler
Comment 12 2021-03-17 11:29:44 PDT
(In reply to Alex Christensen from comment #10) > We assert that they are equal when generating the table. Oh, right, that should have been obvious to me!
Note You need to log in before you can comment on or make changes to this bug.