Bug 223101

Summary: [resultsdbpy] Save identifiers in commit table
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223224
https://bugs.webkit.org/show_bug.cgi?id=221860
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2021-03-11 16:22:54 PST
Commits should be saved with identifiers, hashes and revisions.
Attachments
Patch (28.66 KB, patch)
2021-03-11 16:25 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (28.11 KB, patch)
2021-03-12 15:10 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (38.43 KB, patch)
2021-03-15 16:47 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (35.96 KB, patch)
2021-03-16 09:58 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (46.12 KB, patch)
2021-03-16 16:54 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-11 16:23:07 PST
<rdar://problem/75338338>
Jonathan Bedard
Comment 2 2021-03-11 16:25:17 PST
Created attachment 422989 [details] Patch
Jonathan Bedard
Comment 3 2021-03-12 15:10:28 PST
Created attachment 423085 [details] Patch
dewei_zhu
Comment 4 2021-03-12 15:48:36 PST
Comment on attachment 423085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423085&action=review > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/commit_context.py:390 > + ('identifier', lambda commit: str(commit)), This can be just `str`
Jonathan Bedard
Comment 5 2021-03-15 16:47:27 PDT
Created attachment 423262 [details] Patch
dewei_zhu
Comment 6 2021-03-15 17:11:33 PDT
Comment on attachment 423262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423262&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:156 > + print('{} vs {}'.format(hash_from_id, revision_from_id)) Do we expect this print here?
Jonathan Bedard
Comment 7 2021-03-15 17:14:57 PDT
Comment on attachment 423262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423262&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:156 >> + print('{} vs {}'.format(hash_from_id, revision_from_id)) > > Do we expect this print here? No, I also broke this change out into an independent one: https://bugs.webkit.org/show_bug.cgi?id=223224 (although tests will fail without it, so the independent one needs to land first)
Jonathan Bedard
Comment 8 2021-03-16 09:58:18 PDT
Created attachment 423346 [details] Patch
dewei_zhu
Comment 9 2021-03-16 10:43:20 PDT
r=me
Jonathan Bedard
Comment 10 2021-03-16 16:54:20 PDT
Created attachment 423414 [details] Patch
EWS
Comment 11 2021-03-16 17:53:45 PDT
Committed r274542: <https://commits.webkit.org/r274542> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423414 [details].
Note You need to log in before you can comment on or make changes to this bug.