Bug 223101

Summary: [resultsdbpy] Save identifiers in commit table
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223224
https://bugs.webkit.org/show_bug.cgi?id=221860
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Jonathan Bedard 2021-03-11 16:22:54 PST 
Commits should be saved with identifiers, hashes and revisions.
Comment 1 Radar WebKit Bug Importer 2021-03-11 16:23:07 PST 
<rdar://problem/75338338>
Comment 2 Jonathan Bedard 2021-03-11 16:25:17 PST 
Created attachment 422989 [details]
Patch
Comment 3 Jonathan Bedard 2021-03-12 15:10:28 PST 
Created attachment 423085 [details]
Patch
Comment 4 dewei_zhu 2021-03-12 15:48:36 PST 
Comment on attachment 423085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423085&action=review

> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/commit_context.py:390
> +                ('identifier', lambda commit: str(commit)),

This can be just `str`
Comment 5 Jonathan Bedard 2021-03-15 16:47:27 PDT 
Created attachment 423262 [details]
Patch
Comment 6 dewei_zhu 2021-03-15 17:11:33 PDT 
Comment on attachment 423262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423262&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:156
> +        print('{} vs {}'.format(hash_from_id, revision_from_id))

Do we expect this print here?
Comment 7 Jonathan Bedard 2021-03-15 17:14:57 PDT 
Comment on attachment 423262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423262&action=review

>> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:156
>> +        print('{} vs {}'.format(hash_from_id, revision_from_id))
> 
> Do we expect this print here?

No, I also broke this change out into an independent one: https://bugs.webkit.org/show_bug.cgi?id=223224 (although tests will fail without it, so the independent one needs to land first)
Comment 8 Jonathan Bedard 2021-03-16 09:58:18 PDT 
Created attachment 423346 [details]
Patch
Comment 9 dewei_zhu 2021-03-16 10:43:20 PDT 
r=me
Comment 10 Jonathan Bedard 2021-03-16 16:54:20 PDT 
Created attachment 423414 [details]
Patch
Comment 11 EWS 2021-03-16 17:53:45 PDT 
Committed r274542: <https://commits.webkit.org/r274542>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423414 [details].