Bug 223090

Summary:

Web Inspector: `WI.Object.singleFireEventListener` should not keep a strong reference to `thisObject`

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=196956

Attachments:

Description	Flags
Patch	none

Description Devin Rousso 2021-03-11 14:05:03 PST

Comment 1 Devin Rousso 2021-03-11 14:13:07 PST

Created attachment 422965 [details]
Patch

Comment 2 BJ Burg 2021-03-11 14:26:33 PST

Comment on attachment 422965 [details]
Patch

r=me

Is this testable?

Comment 3 Devin Rousso 2021-03-11 14:49:19 PST

Comment on attachment 422965 [details]
Patch

(In reply to BJ Burg from comment #2) 
> Is this testable?
not in any reliable way that I know of (especially given conservative GC) :/

Comment 4 EWS 2021-03-11 15:11:25 PST

Committed r274303: <https://commits.webkit.org/r274303>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422965 [details].

Comment 5 Radar WebKit Bug Importer 2021-03-11 15:12:16 PST

<rdar://problem/75335202>