Bug 223087 – Introduce WorkQueue::main() to get the main thread's work queue

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Chris Dumez]

Introduce WorkQueue::main() to get the main thread's work queue. This allows us to port some more code from dispatch_queue to WorkQueue. It also simplifies some code that has to deal that sometimes needs to run on the main thread and other times on a background queue. Having a single WorkQueue type to represent both the main thread and a background queue makes writing such code more convenient.

[Chris Dumez]

Created attachment 422962 [details]
Patch

[Chris Dumez]

Created attachment 422964 [details]
Patch

[Chris Dumez]

Created attachment 422967 [details]
Patch

[Chris Dumez]

Created attachment 422972 [details]
Patch

[Geoffrey Garen]

Comment on attachment 422972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422972&action=review

r=me

> Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:214
> -    dispatch_async(dispatch_get_main_queue(), makeBlockPtr([this, strongThis = makeRef(*this), callbackID] {
> +    WorkQueue::main().dispatch([this, strongThis = makeRef(*this), callbackID] {

I wonder about cases like this. Do they use WorkQueue rather than RunLoop for any specific purpose? Perhaps we should just make RunLoop::main() safe to call before main thread initialization, just like WorkQueue::main.

[Chris Dumez]

(In reply to Geoffrey Garen from comment #5)
> Comment on attachment 422972 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422972&action=review
> 
> r=me
> 
> > Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:214
> > -    dispatch_async(dispatch_get_main_queue(), makeBlockPtr([this, strongThis = makeRef(*this), callbackID] {
> > +    WorkQueue::main().dispatch([this, strongThis = makeRef(*this), callbackID] {
> 
> I wonder about cases like this. Do they use WorkQueue rather than RunLoop
> for any specific purpose? Perhaps we should just make RunLoop::main() safe
> to call before main thread initialization, just like WorkQueue::main.

There is a CFRunLoopGetMain() so in theory, we should be able to get RunLoop::main() working before main thread initialization?

[Geoffrey Garen]

Right, I think so.

[Chris Dumez]

Comment on attachment 422972 [details]
Patch

Clearing flags on attachment: 422972

Committed r274307 (235201@main): <https://commits.webkit.org/235201@main>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/75337395>