Summary: | Improve Worker GC behavior | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | WebCore JavaScript | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2008-11-17 06:18:07 PST
Created attachment 25211 [details]
proposed patch
Comment on attachment 25211 [details] proposed patch > + Made hasPendingActivity() virtul, letting Worker add behavior to it. Misspelled virtual here. > + m_workerContext->thread()->messagingProxy()->reportWorkerThreadActivity(false, m_workerContext->hasPendingActivity()); The use of booleans makes this a little hard to read. It's not obvious what that false means. We can use enums to construct named booleans which help make call sites like this easier to read. r=me Committed revision 38549. (In reply to comment #2) > > + m_workerContext->thread()->messagingProxy()->reportWorkerThreadActivity(false, m_workerContext->hasPendingActivity()); > > The use of booleans makes this a little hard to read. It's not obvious what > that false means. We can use enums to construct named booleans which help make > call sites like this easier to read. I've split this into two functions, reportWorkerThreadActivity and confirmWorkerThreadMessage. |