Bug 223052

Summary:

AI validator patchpoint should read heap top

Product:

WebKit

Reporter:

Tadeu Zagallo <tzagallo>

Component:

JavaScriptCore

Assignee:

Tadeu Zagallo <tzagallo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, ryanhaddad, saam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

223064

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Tadeu Zagallo

Reported 2021-03-10 16:01:38 PST

<rdar://75087095>

Attachments
Patch (2.75 KB, patch) 2021-03-10 16:04 PST, Tadeu Zagallo	no flags	Details Formatted Diff Diff
Patch (2.88 KB, patch) 2021-03-11 14:14 PST, Tadeu Zagallo	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tadeu Zagallo

Comment 1 2021-03-10 16:04:31 PST

Created attachment 422886 [details] Patch

EWS

Comment 2 2021-03-10 18:39:22 PST

Committed r274263: <https://commits.webkit.org/r274263> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422886 [details].

Aakash Jain

Comment 3 2021-03-11 03:43:48 PST

(In reply to EWS from comment #2) > Committed r274263: <https://commits.webkit.org/r274263> Few jsc tests which were added in this commit seems to be consistently failing for armv7 and mipsel, e.g.: https://results.webkit.org/?suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&test=stress%2Fprivate-methods-inheritance.js.bytecode-cache&test=stress%2Fprivate-methods-inheritance.js.default&test=stress%2Fprivate-methods-inheritance.js.no-llint Also confirmed by EWS in: https://ews-build.webkit.org/#/builders/46/builds/6719 https://ews-build.webkit.org/#/builders/45/builds/2939

WebKit Commit Bot

Comment 4 2021-03-11 03:44:41 PST

Re-opened since this is blocked by bug 223064

Tadeu Zagallo

Comment 5 2021-03-11 14:14:15 PST

Created attachment 422966 [details] Patch

EWS

Comment 6 2021-03-11 16:47:27 PST

Committed r274312: <https://commits.webkit.org/r274312> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422966 [details].

Note You need to log in before you can comment on or make changes to this bug.