Bug 223049

Summary: Introduce WorkQueue::dispatchSync()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, berto, cgarcia, cmarcelo, darin, ews-watchlist, ggaren, gustavo, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 223030    
Bug Blocks: 223073    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-03-10 14:56:37 PST
Introduce WorkQueue::dispatchSync(), which relies on GCD's dispatch_sync() internally on Cocoa ports.
Attachments
Patch (16.70 KB, patch)
2021-03-10 15:00 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (16.63 KB, patch)
2021-03-10 17:34 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (16.76 KB, patch)
2021-03-11 08:15 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (16.72 KB, patch)
2021-03-11 08:40 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-03-10 15:00:04 PST
Created attachment 422875 [details] Patch
EWS Watchlist
Comment 2 2021-03-10 15:01:03 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Chris Dumez
Comment 3 2021-03-10 17:34:30 PST
Created attachment 422888 [details] Patch
Alex Christensen
Comment 4 2021-03-11 07:44:57 PST
Comment on attachment 422888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422888&action=review > Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:50 > + dispatch_sync(m_dispatchQueue.get(), makeBlockPtr([protectedThis = makeRef(*this), function = WTFMove(function)] { Do we need to protect this, since we won't return until the dispatch_sync returns?
Chris Dumez
Comment 5 2021-03-11 08:15:10 PST
Created attachment 422932 [details] Patch
Alex Christensen
Comment 6 2021-03-11 08:39:10 PST
Comment on attachment 422932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422932&action=review > Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:50 > + dispatch_sync(m_dispatchQueue.get(), makeBlockPtr([function = WTFMove(function)] { I don't think we need to make a lambda to wrap this function. makeBlockPtr(WTFMove(function))
Chris Dumez
Comment 7 2021-03-11 08:40:44 PST
Created attachment 422936 [details] Patch
EWS
Comment 8 2021-03-11 10:00:36 PST
Committed r274286: <https://commits.webkit.org/r274286> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422936 [details].
Radar WebKit Bug Importer
Comment 9 2021-03-11 10:01:30 PST
<rdar://problem/75320966>
Note You need to log in before you can comment on or make changes to this bug.