Bug 222988

Summary:

[ BigSur wk2 arm64 ] quite a few fast/forms (Layout-Tests) are text failing on Apple Silicon

Product:

WebKit

Reporter:

Robert Jenner <jenner>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akeerthi, ap, cdumez, pvollan, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=222619
https://bugs.webkit.org/show_bug.cgi?id=222825

Attachments:

Description	Flags
File for all of the Text Diffs	none

Robert Jenner

Reported 2021-03-09 12:40:39 PST

Attachments
File for all of the Text Diffs (27.26 KB, application/zip) 2021-03-09 13:12 PST, Robert Jenner	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-03-09 12:41:03 PST

<rdar://problem/75230416>

Robert Jenner

Comment 2 2021-03-09 12:43:06 PST

I do not have access to an Apple Silicon Mac, so I cannot reproduce the failures. However, I will say that they are the same test family, and they share the same failure history. These tests may just need an adjustment to run on Apple Silicon.

Robert Jenner

Comment 3 2021-03-09 13:12:22 PST

Created attachment 422750 [details] File for all of the Text Diffs These are all of the text DIFF files for all 17 of the failures. I put them in a folder, and also broke them down by the type of failure they were having. There are four categories of text failures these tests are having: blur/FocusEventsFired input.value numberOfFields RenderText

Aditya Keerthi

Comment 4 2021-03-09 13:39:56 PST

Based on the diffs attached it appears as though these tests are failing due to a different language/locale on the Apple Silicon bots. The system language affects the order of fields for the date/time tests, leading to different values when editing the input. Note that fast/text/hyphenate-locale.html doesn't belong to the same family as the other tests (date/time inputs), but is a test that is affected by locale. The easiest way to fix this would be to update the system language/locale on the bots. A better solution would be to make these tests independent of the system language/locale. I will see if it's possible to rewrite these tests.

Ryan Haddad

Comment 5 2021-03-09 14:05:19 PST

I did find that a handful of these machines were configured with en-GB as the language, though I'm not sure how they ended up in this state. I have now ensured that they are all configured as en-US / en_US, so lets continue to monitor the results to see what happens.

Ryan Haddad

Comment 6 2021-03-09 20:34:26 PST

The failures disappeared on the next run after I reset the language: https://build.webkit.org/results/Apple-BigSur-Release-AppleSilicon-WK2-Tests/r274171%20(114)/results.html However, 8/10 of these bots are back on en-GB again, so the theory that this is due to a test changing the language and not returning it to the original one is back on the table Presumably, https://bugs.webkit.org/show_bug.cgi?id=222619 would be a culprit.

Chris Dumez

Comment 7 2021-03-09 20:51:45 PST

Committed r274195 (235113@main): <https://commits.webkit.org/235113@main>

Chris Dumez

Comment 8 2021-03-09 20:53:12 PST

Please reset the language on these bots to en-US one more time. My patch should make sure it does not get modified to en-GB again.

Alexey Proskuryakov

Comment 9 2021-03-10 10:16:08 PST

Is there a root cause with potentially user facing symptoms to be worried about?

Chris Dumez

Comment 10 2021-03-10 10:23:37 PST

(In reply to Alexey Proskuryakov from comment #9) > Is there a root cause with potentially user facing symptoms to be worried > about? Tracked by Bug 222825. It seems the languagechange event may not be firing on Big Sur / Apple Silicon (even though it does on Intel). This is likely not a regression, just a new find because of the newly added API test.

Note You need to log in before you can comment on or make changes to this bug.