Bug 222971

Summary: [JHBuild] Update dav1d to 0.8.2
Product: WebKit Reporter: Ewout ter Hoeven <E.M.terHoeven>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, calvaris, changseok, clopez, dev, ews-watchlist, ltilve, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
dav1d 0.8.2 patch ews-feeder: commit-queue-

Ewout ter Hoeven
Reported 2021-03-09 06:01:10 PST
Created attachment 422690 [details] dav1d 0.8.2 patch Updates dav1d from 0.7.0 to 0.8.2, improving decoding speed, reducing CPU usage and improving security. Patch is attached. dav1d changelog: https://code.videolan.org/videolan/dav1d/-/blob/master/NEWS
Attachments
dav1d 0.8.2 patch (1.14 KB, patch)
2021-03-09 06:01 PST, Ewout ter Hoeven
ews-feeder: commit-queue-
ChangSeok Oh
Comment 1 2021-03-09 17:16:58 PST
(In reply to Ewout ter Hoeven from comment #0) > Created attachment 422690 [details] > dav1d 0.8.2 patch > > Updates dav1d from 0.7.0 to 0.8.2, improving decoding speed, reducing CPU > usage and improving security. Patch is attached. > > dav1d changelog: https://code.videolan.org/videolan/dav1d/-/blob/master/NEWS Thanks for this a heads up. AVIF support in webkit is experimental, not for production. Definitely, we will consider bumping up the versions of libavif and dav1d.
Philippe Normand
Comment 2 2021-03-10 00:56:53 PST
ChangeLog needed! See https://webkit.org/contributing-code/ for the whole procedure.
Philippe Normand
Comment 3 2021-03-10 04:30:41 PST
Also most of our (GTK/WPE) build bots now rely on the Flatpak SDK for dependencies. It's less easier to update though, I can take care of it in a follow-up patch.
Philippe Normand
Comment 4 2021-03-10 04:32:09 PST
(In reply to ChangSeok Oh from comment #1) > (In reply to Ewout ter Hoeven from comment #0) > > Created attachment 422690 [details] > > dav1d 0.8.2 patch > > > > Updates dav1d from 0.7.0 to 0.8.2, improving decoding speed, reducing CPU > > usage and improving security. Patch is attached. > > > > dav1d changelog: https://code.videolan.org/videolan/dav1d/-/blob/master/NEWS > > Thanks for this a heads up. AVIF support in webkit is experimental, not for > production. Definitely, we will consider bumping up the versions of libavif > and dav1d. Maybe we can consider enabling it by default for the next cycle though? 2.34 scheduled for September/October 2021.
Ewout ter Hoeven
Comment 5 2021-03-10 05:52:35 PST
I used the GitHub mirror to create and test this patch, haven't used SVN before, if someone could generate a ChangeLog file for me that would be awesome, otherwise I will dive in next week. It's a very small change, so if anyone wants to patch it themselves using the correct WebKit procedures, feel free to do so. Targeting AVIF support enabled by default would be a great goal! It's tricky though, and will need a lot of testing, Firefox had to roll back for the 86 release for example: https://bugzilla.mozilla.org/show_bug.cgi?id=1682995#c22 Should we create a tracking issue for enabling AVIF decoding by default?
Xabier Rodríguez Calvar
Comment 6 2021-03-10 07:09:18 PST
(In reply to Ewout ter Hoeven from comment #5) > I used the GitHub mirror to create and test this patch, haven't used SVN > before, if someone could generate a ChangeLog file for me that would be > awesome, otherwise I will dive in next week. It's a very small change, so if > anyone wants to patch it themselves using the correct WebKit procedures, > feel free to do so. There is a Tools/Scripts/prepare-changelogs script. It will create the skeleton that you need to fill.
Radar WebKit Bug Importer
Comment 7 2021-03-16 07:02:16 PDT
Ewout ter Hoeven
Comment 8 2021-04-10 06:11:20 PDT
This was handled in https://bugs.webkit.org/show_bug.cgi?id=224177, so changing the status of this bug in RESOLVED FIXED. Thanks for the effort Philippe!
Note You need to log in before you can comment on or make changes to this bug.