Bug 222946

Summary: [webkitscmpy] Isolate dateutil imports
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223006
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2021-03-08 15:43:41 PST
dateutil has issues installing on some platforms because it relies on pip. It's only used for unit testing anyways, so let's isolate those imports to the functions that require them.
Attachments
Patch (2.72 KB, patch)
2021-03-08 15:45 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.32 KB, patch)
2021-03-08 17:23 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-08 15:44:01 PST
<rdar://problem/75191226>
Jonathan Bedard
Comment 2 2021-03-08 15:45:46 PST
Created attachment 422627 [details] Patch
Jonathan Bedard
Comment 3 2021-03-08 17:23:30 PST
Created attachment 422643 [details] Patch for landing
EWS
Comment 4 2021-03-08 18:10:14 PST
Committed r274127: <https://commits.webkit.org/r274127> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422643 [details].
Note You need to log in before you can comment on or make changes to this bug.