Bug 222919

Summary: [Cocoa] Add additional bundle ID property to WKWebViewConfiguration
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brent Fulgham
Reported 2021-03-08 10:03:49 PST
Add an additional property to WKWebViewConfiguration to help thread the correct bundle ID of the driving application so that WebKit can provide better messaging when Safari View Controller (or ASWebAuthenticationSession) is used. Currently we often have to report a generic "web content" message that doesn't help a user see which app is actually requesting the load. @interface WKWebViewConfiguration (WKPrivate) @property (nonatomic, setter=_setAttributedBundleIdentifier:) NSString * _attributedBundleIdentifier WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); @end WKWebViewConfiguration._attributedBundleIdentifier
Attachments
Patch (13.91 KB, patch)
2021-03-09 10:43 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (17.52 KB, patch)
2021-03-09 11:37 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-08 10:04:14 PST
<rdar://problem/75175422>
Brent Fulgham
Comment 2 2021-03-08 16:40:45 PST
This is actually: <rdar://problem/75013854>
Brent Fulgham
Comment 3 2021-03-09 10:43:34 PST
Created attachment 422725 [details] Patch
Alex Christensen
Comment 4 2021-03-09 11:14:32 PST
Comment on attachment 422725 [details] Patch Looks good, but you'll need to copy this new member in WebsiteDataStoreConfiguration::copy
Brent Fulgham
Comment 5 2021-03-09 11:37:03 PST
Created attachment 422735 [details] Patch
Brent Fulgham
Comment 6 2021-03-09 15:22:48 PST
Let's hold off on landing until we confirm this is the final shape of this solution.
Brent Fulgham
Comment 7 2021-03-09 15:23:14 PST
Comment on attachment 422735 [details] Patch Marking cq- so no one lands this before we finalize the design choice.
Brent Fulgham
Comment 8 2021-03-10 11:44:48 PST
Comment on attachment 422735 [details] Patch Confirmed this is how we intend to handle this.
EWS
Comment 9 2021-03-10 12:09:35 PST
Committed r274228: <https://commits.webkit.org/r274228> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422735 [details].
Note You need to log in before you can comment on or make changes to this bug.